Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with focused notebook cells being unrendered #99390

Closed
roblourens opened this issue Jun 4, 2020 · 0 comments
Closed

Issues with focused notebook cells being unrendered #99390

roblourens opened this issue Jun 4, 2020 · 0 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook
Milestone

Comments

@roblourens
Copy link
Member

From #99354

  • Focus a notebook cell
  • Scroll so that it's out of the viewport
  • Now that element doesn't exist, so it can't be focused, so context keys that depend on that row's context key service won't apply, and keybindings that should be handled by the list (like arrow keys) won't be executed

Probably the easiest fix is to get rid of the row element-level focus concept, and figure out how to adjust context keys to compensate for it. Or, don't unrender the focused cell element and keep it around but invisible somewhere.

@roblourens roblourens added debt Code quality issues notebook labels Jun 4, 2020
@roblourens roblourens added this to the June 2020 milestone Jun 4, 2020
@roblourens roblourens self-assigned this Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook
Projects
None yet
Development

No branches or pull requests

2 participants
@roblourens and others