Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tree view for find all references is no longer accessible for NVDA users #99563

Closed
Neurrone opened this issue Jun 7, 2020 · 13 comments
Closed

The tree view for find all references is no longer accessible for NVDA users #99563

Neurrone opened this issue Jun 7, 2020 · 13 comments
Assignees
@isidorn @alexr00
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Milestone
June 2020

Comments

@Neurrone
Copy link

Neurrone commented Jun 7, 2020

CC: @isidorn

Issue Type: Bug

  1. press alt+shift+f12 to find all references.

Expected: NVDA correctly reads the labels, and the tree information for the selected item

Actual: part of the label appears to be truncated and not announced, no info on tree level and expanded / collapsed state announced, making this hard to use.

VS Code version: Code - Insiders 1.46.0-insider (b1ef2bf, 2020-06-05T12:30:13.870Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.86GB (5.94GB free)
Process Argv
Screen Reader yes
VM 0%
Extensions (13)
Extension Author (truncated) Version
notes can 1.0.1
vscode-markdownlint Dav 0.36.0
vscode-eslint dba 2.1.5
prettier-vscode esb 5.0.0
rest-client hum 0.23.2
python ms- 2020.5.80290
remote-wsl ms- 0.44.2
cpptools ms- 0.28.2
Go ms- 0.14.3
vsnotes pat 0.7.1
rust rus 0.7.8
markdown-preview-enhanced shd 0.5.10
vscode-webhint web 1.5.6
@Neurrone Neurrone mentioned this issue Jun 7, 2020
Closed
@isidorn isidorn self-assigned this Jun 8, 2020
@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 8, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 8, 2020

Thanks for filling this and I can partialy reproduce this.
The issue is that in the references view the File elements do not have an aria label set it seems.
So I think that here we return null for file elements.
As for the aria-expanded property it seems to be set properly with all the other aria elements.

@jrieken can you please look into this aria label not being returned? If you are busy let me know and I can also investigate.

@jrieken
Copy link
Member

jrieken commented Jun 8, 2020

@jrieken can you please look into this aria label not being returned?

We never did that for the references viewlet, the API proposal for that is pretty fresh so isn't the real question what has changes so that this regressed?

@isidorn
Copy link
Contributor

isidorn commented Jun 8, 2020

@jrieken I am not when and if this was working, since I did not check this before.
@Neurrone was this working before? If so do you know when

@jrieken what API proposal do you mean? Can't we just return the name and the relative path as part for the aria label?

@jrieken
Copy link
Member

jrieken commented Jun 8, 2020

@jrieken what API proposal do you mean?

Your API proposal for the aria text on tree items. The references viewlet is an extension

@isidorn
Copy link
Contributor

isidorn commented Jun 8, 2020

Yeah I always forget that.
Anyways I tried with vs code stable and I see the same behavior. So it seems there is no regression here. @Neurrone can correct me if wrong
And when possible the references viewlet should jump on the new API.

@jrieken
Copy link
Member

jrieken commented Jun 8, 2020

And when possible the references viewlet should jump on the new API.

Sure, can do that but the contents of the reference viewlet aren't so exotic that the default shouldn't work. No codicons or such, mostly file names, paths. Maybe the highlights are trouble some here

@jrieken
Copy link
Member

jrieken commented Jun 8, 2020

/cc @alexr00

@Neurrone
Copy link
Author

Neurrone commented Jun 8, 2020

I don't recall exactly when this broke or if it was working before. Should I go a few months back to see if this was working before?

@isidorn
Copy link
Contributor

isidorn commented Jun 8, 2020

@Neurrone I checked the last stable I get the same behavior. However please note my comment that the only missing thing is for file elements, for the actual reference elements all is good for me.
If you want you can check last 2 stable releases and let us know

@Neurrone
Copy link
Author

Neurrone commented Jun 8, 2020

For the actual reference elements, they do read the label, but the level information is missing.

@alexr00 alexr00 added this to the June 2020 milestone Jun 15, 2020
@alexr00
Copy link
Member

alexr00 commented Jun 15, 2020 •
edited

Introduced by 6e50f24

@isidorn
Copy link
Contributor

isidorn commented Jun 15, 2020

@alexr00 sorry about the breakage! Are you already looking into this? I can also dive in if needed.

@alexr00
Copy link
Member

alexr00 commented Jun 15, 2020

@isidorn I'm already looking, I just dropped the commit in there so I can keep track of it!

@jrieken jrieken removed their assignment Jun 15, 2020
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2020
@bpasero bpasero added the verified Verification succeeded label Jul 3, 2020
@ejizba ejizba mentioned this issue Jul 20, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@alexr00 alexr00

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
6 participants
@bpasero @jrieken @isidorn @Neurrone @alexr00 and others