Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editors comparing files do not restore after reload #99659

Closed
bpasero opened this issue Jun 9, 2020 · 1 comment
Closed

Diff editors comparing files do not restore after reload #99659

bpasero opened this issue Jun 9, 2020 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
June 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jun 9, 2020

Steps to Reproduce:

  1. compare 2 files
  2. reload window

=> 馃悰 the diff editor does not restore
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels Jun 9, 2020
@bpasero bpasero added this to the June 2020 milestone Jun 9, 2020
@bpasero bpasero self-assigned this Jun 9, 2020
@bpasero bpasero added the workbench-editors Managing of editor widgets in workbench window label Jun 9, 2020
@bpasero bpasero closed this as completed in 1428d44 Jun 9, 2020
@bpasero
Copy link
Member Author

bpasero commented Jun 9, 2020

Verification: besides the bug to verify, also make sure that view state is properly restored, e.g. the selected lines.

@mjbvz mjbvz added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
3 participants
@bpasero @mjbvz and others