Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of values- and keys-utils #99664

Closed
42 tasks done
jrieken opened this issue Jun 9, 2020 · 4 comments
Closed
42 tasks done

Remove usages of values- and keys-utils #99664

jrieken opened this issue Jun 9, 2020 · 4 comments
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
July 2020

Comments

@jrieken
Copy link
Member

jrieken commented Jun 9, 2020 •
edited by sandy081
Loading

We have utilities to get all values or key from ES6 maps. Since we are actually targeting ES6 at runtime these utils aren't needed anymore and you should just use someMap.keys() or someMap.values()

  • src/vs/base/browser/ui/tree/abstractTree.ts @joaomoreno
  • src/vs/base/browser/ui/tree/asyncDataTree.ts @joaomoreno
  • src/vs/base/common/resourceTree.ts @joaomoreno
  • src/vs/editor/common/modes/tokenizationRegistry.ts @alexdima
  • src/vs/editor/common/services/markerDecorationsServiceImpl.ts @sandy081
  • src/vs/platform/configuration/common/configurationModels.ts @sandy081
  • src/vs/platform/configuration/common/configurationRegistry.ts @sandy081
  • src/vs/platform/contextkey/browser/contextKeyService.ts @alexdima
  • src/vs/platform/extensionManagement/common/extensionGalleryService.ts @sandy081
  • src/vs/platform/extensionManagement/common/extensionTipsService.ts @sandy081
  • src/vs/platform/keybinding/common/keybindingResolver.ts @alexdima
  • src/vs/platform/url/common/urlService.ts @joaomoreno
  • src/vs/platform/userDataSync/common/extensionsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/extensionsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/globalStateMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/keybindingsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/keybindingsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/settingsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/snippetsMerge.ts @sandy081
  • src/vs/platform/userDataSync/common/storageKeys.ts @sandy081
  • src/vs/workbench/api/browser/mainThreadComments.ts @rebornix
  • src/vs/workbench/api/browser/mainThreadSearch.ts @roblourens
  • src/vs/workbench/common/views.ts @sbatten
  • src/vs/workbench/common/views.ts @sbatten
  • src/vs/workbench/contrib/comments/common/commentModel.ts @rebornix
  • src/vs/workbench/contrib/extensions/browser/configBasedRecommendations.ts @sandy081
  • src/vs/workbench/contrib/extensions/browser/extensionsDependencyChecker.ts @sandy081
  • src/vs/workbench/contrib/files/browser/views/explorerView.ts @isidorn
  • src/vs/workbench/contrib/search/common/queryBuilder.ts @roblourens
  • src/vs/workbench/contrib/search/common/searchModel.ts @roblourens
  • src/vs/workbench/services/extensions/common/extensionsRegistry.ts @alexdima
  • src/vs/workbench/services/extensions/electron-browser/remoteExtensionManagementIpc.ts @alexdima
  • src/vs/workbench/services/log/common/inMemoryLogProvider.ts @sandy081
  • src/vs/workbench/services/log/common/keyValueLogProvider.ts @sandy081
  • src/vs/workbench/services/preferences/common/preferencesModels.ts @sandy081
  • src/vs/workbench/services/preferences/common/preferencesModels.ts @sandy081
  • src/vs/workbench/services/search/common/searchService.ts @roblourens
  • src/vs/workbench/services/search/common/searchService.ts @roblourens
  • src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts @sandy081
  • src/vs/workbench/services/views/common/viewContainerModel.ts @sbatten
  • src/vs/workbench/services/search/common/searchService.ts @roblourens
  • src/vs/workbench/contrib/comments/common/commentModel.ts @rebornix
@jrieken jrieken added the debt Code quality issues label Jun 9, 2020
@jrieken
Copy link
Member Author

jrieken commented Jun 9, 2020

fyi - more obsolete utils can be found with this search editor-file: .vscode/searches/es6.code-search

@joaomoreno joaomoreno removed their assignment Jun 10, 2020
joaomoreno added a commit that referenced this issue Jun 10, 2020
@joaomoreno
cleanup ES6 iterables utils
4b15134 
related to #99664
aeschli pushed a commit that referenced this issue Jun 10, 2020
@joaomoreno @aeschli
cleanup ES6 iterables utils
eb278d3 
related to #99664
roblourens added a commit that referenced this issue Jun 10, 2020
@roblourens
Removes usages of deprecated values helper
34573b3 
#99664
@rebornix rebornix removed their assignment Jun 24, 2020
alexdima added a commit that referenced this issue Jul 7, 2020
@alexdima
Reduce usage of utilities (for #99664)
7b29e7c
@alexdima alexdima removed their assignment Jul 7, 2020
@sandy081 sandy081 added this to the July 2020 milestone Jul 8, 2020
sandy081 added a commit that referenced this issue Jul 8, 2020
@sandy081
#99664 do not use deprecated values util
648e559
sandy081 added a commit that referenced this issue Jul 8, 2020
@sandy081
#99664 remove usage of deprecated keys util
c031980
sandy081 added a commit that referenced this issue Jul 8, 2020
@sandy081
#99664 Remove last usages of keys and values @rebornix @roblourens FYI
0f91e23
@sandy081
Copy link
Member

sandy081 commented Jul 8, 2020

@rebornix @roblourens Since there were only last two usages left each from you, cleaned them up myself.

@sandy081
Copy link
Member

sandy081 commented Jul 8, 2020

@jrieken Also removed these utils as there are no longer usages of these in code.

@jrieken
Copy link
Member Author

jrieken commented Jul 8, 2020

👏

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
7 participants
@joaomoreno @rebornix @jrieken @alexdima @sbatten @sandy081 and others