Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does callback.html live in scripts? #99666

Closed
Tyriar opened this issue Jun 9, 2020 · 2 comments
Closed

Why does callback.html live in scripts? #99666

Tyriar opened this issue Jun 9, 2020 · 2 comments
Assignees
@eamodio
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
June 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2020

I always use ./sc tab c tab to launch which now completes callback.html in pwsh
@bpasero
Copy link
Member

bpasero commented Jun 9, 2020

Yup, we should have a dedicated folder for code-web.js and callback.html, maybe resources/server(less)

@eamodio
Copy link
Contributor

eamodio commented Jun 9, 2020

Yeah, I will be moving those today.

@eamodio eamodio closed this as completed in bb97e45 Jun 9, 2020
@Tyriar Tyriar added this to the June 2020 milestone Jun 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Fixes microsoft#99666 - moves code-web into resources/
1db0999
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Fixes microsoft#99666 - moves code-web into resources/
db2bd9a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@eamodio @bpasero @Tyriar and others