Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: tab order is funky #99782

Closed
isidorn opened this issue Jun 10, 2020 · 2 comments
Closed

Notebook: tab order is funky #99782

isidorn opened this issue Jun 10, 2020 · 2 comments
Assignees
@roblourens
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
June 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 10, 2020 •
edited by roblourens

I like the up / down keyboard navigation over notebook cells, but when you try to use tab to navigate the order is very unexpected.

  1. Focus a notebook. I am using my-work.github-issues my work cell
  2. Press tab -> Focus is on GitHub issues label
  3. Press tab -> focus seems lost
  4. Press tab -> focus is on the start of the document, even though I did not traverse until the end of the docuemnt

Ideally tab should go in visual order. If that is not possible tab should move focus out of the notebook. Similarly tree tab is not used to move focus so users use up / down, but pressing tab focuses out of the tree and does not lead to unexpected jumping of focus.
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook labels Jun 10, 2020
@jrieken jrieken assigned roblourens and unassigned jrieken Jun 11, 2020
@roblourens roblourens added this to the June 2020 milestone Jun 12, 2020
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jun 12, 2020
roblourens added a commit that referenced this issue Jun 14, 2020
@roblourens
Fix list focusing for #99782
06dac2c
@roblourens roblourens mentioned this issue Jun 14, 2020
Merged
@roblourens
Copy link
Member

Fixed in this change

  • Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell (step 3 in OP)
  • Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn
  • Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in listCommands.ts)

roblourens added a commit that referenced this issue Jun 15, 2020
@roblourens
Fix some notebook cell focus/tabbing issues
1a8331f 
- Get rid of output focus sink when cell has no output, to avoid a dead spot when tabbing through cell
- Fix the toolbar losing focus shortly after tabbing onto it, by avoid context key churn
- Fix domFocus when focus is in a different element from the one that is selected (depends on an earlier PR in listCommands.ts)
Fix #99782
@isidorn
Copy link
Contributor Author

isidorn commented Jun 29, 2020

Much better now. Thanks for fixing this.

@isidorn isidorn added the verified Verification succeeded label Jun 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@roblourens @rebornix @jrieken @isidorn