Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataCollector throws error when friendly name is missing #1952

Closed
vagisha-nidhi opened this issue Mar 12, 2019 · 2 comments
Closed

DataCollector throws error when friendly name is missing #1952

vagisha-nidhi opened this issue Mar 12, 2019 · 2 comments
Labels

Comments

@vagisha-nidhi
Copy link
Contributor

Description

DataCollector throws error when friendly name is missing even though providing URI in the runsettings.

Steps to reproduce

I used the below .runsettings

<RunSettings>  
  <DataCollectionRunSettings>
  <DataCollectors>
    <!-- https://docs.microsoft.com/en-us/visualstudio/test/customizing-code-coverage-analysis -->
    <DataCollector uri="datacollector://Microsoft/CodeCoverage/2.0"
                   assemblyQualifiedName="Microsoft.VisualStudio.Coverage.DynamicCoverageDataCollector, Microsoft.VisualStudio.TraceCollector, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" >
      <Configuration>
        <CodeCoverage>
          <ModulePaths>
            <Exclude>
              <ModulePath>.*FakeItEasy.*</ModulePath>
              <ModulePath>.*GongSolutions.WPF.DragDrop.*</ModulePath>
            </Exclude>
          </ModulePaths>
        </CodeCoverage>
      </Configuration>
    </DataCollector>
  </DataCollectors>
</DataCollectionRunSettings>
</RunSettings>

command line
vstest.console.exe C:\CodeBase\CoverageCheck\CoverageCheck\bin\Debug\netcoreapp2.2\CoverageCheck.dll /settings:"C:\CodeBase\CoverageCheck\coverage.runsettings"

Expected behavior

Code coverage data collector should work even if friendly name is not provided.

Actual behavior

Microsoft (R) Test Execution Command Line Tool Version 16.0.1-dev
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Invalid data collector settings. Expected attribute 'FriendlyName' is missing.  A typical data collector setting would look like <DataCollector uri="dataCollector://Samples/SampleCollector/1.0" assemblyQualifiedName="Samples.SampleCollector.SampleDataCollector, SampleCollectors, Version=1.0.0.0, Culture=neutral, PublicKeyToken=1111111111111111" friendlyName="sampleCollector">.
@singhsarab
Copy link
Contributor

/cc: @hvinett

@mayankbansal018
Copy link
Contributor

@hvinett @singhsarab this is closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants