Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Uploaded VSIX extension package for version 1.1.2 is missing the taco-team-build node module for the Cordova command tasks #24

Closed
Chuxel opened this issue Jan 21, 2016 · 1 comment

Comments

@Chuxel
Copy link
Member

Chuxel commented Jan 21, 2016

It looks like we messed up when generating the 1.1.2 VSIX and the "Command" tasks are missing a node module. Unclear why we didn't see this in some instances but in fresh ones, executing these commands results in a module not found error in fresh VSTS instances quite consistently.

I found the VSIX Peter generated and these tasks are missing the node_modules folder and the core cause is that the VSIX creation script does not do npm install on all the sub tasks like upload does. That makes it easy to miss this step. We’ve probably just been lucky so far that whoever created the VSIX happened to be the same person that used the upload script for testing. (Dan generally had been doing both testing and VSIX creation.) I am not entirely sure why this only happens in new VSTS instances, however.

I created a branch to do a tactical release for 1.1.3 to fix this but it reverts Peter's most recent commit: https://github.com/Microsoft/vsts-cordova-tasks/tree/1.1.3

Before we do another release, we need to either merge in 1.1.3 and then re-do Peters commit or simply:

  1. Bump the VSIX version up to at least 1.1.4
  2. Bump all task versions up two versions in master

Further, we should:

  1. Fix makevsix.cmd so that it does npm installs for each tasks to avoid this from happening in the future.
  2. Create a separate manifest with a dev ID for the VSIX that is "private" that we can use for testing prior to full releases
@Chuxel
Copy link
Member Author

Chuxel commented Jan 21, 2016

We can publish 1.1.3 out of the 1.1.3 release branch since it has no functional changes over 1.1.2, but we'll want to make sure we get this resolved before doing a 1.1.4.

@Chuxel Chuxel closed this as completed Feb 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant