You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
It looks like we messed up when generating the 1.1.2 VSIX and the "Command" tasks are missing a node module. Unclear why we didn't see this in some instances but in fresh ones, executing these commands results in a module not found error in fresh VSTS instances quite consistently.
I found the VSIX Peter generated and these tasks are missing the node_modules folder and the core cause is that the VSIX creation script does not do npm install on all the sub tasks like upload does. That makes it easy to miss this step. We’ve probably just been lucky so far that whoever created the VSIX happened to be the same person that used the upload script for testing. (Dan generally had been doing both testing and VSIX creation.) I am not entirely sure why this only happens in new VSTS instances, however.
We can publish 1.1.3 out of the 1.1.3 release branch since it has no functional changes over 1.1.2, but we'll want to make sure we get this resolved before doing a 1.1.4.
It looks like we messed up when generating the 1.1.2 VSIX and the "Command" tasks are missing a node module. Unclear why we didn't see this in some instances but in fresh ones, executing these commands results in a module not found error in fresh VSTS instances quite consistently.
I found the VSIX Peter generated and these tasks are missing the node_modules folder and the core cause is that the VSIX creation script does not do npm install on all the sub tasks like upload does. That makes it easy to miss this step. We’ve probably just been lucky so far that whoever created the VSIX happened to be the same person that used the upload script for testing. (Dan generally had been doing both testing and VSIX creation.) I am not entirely sure why this only happens in new VSTS instances, however.
I created a branch to do a tactical release for 1.1.3 to fix this but it reverts Peter's most recent commit: https://github.com/Microsoft/vsts-cordova-tasks/tree/1.1.3
Before we do another release, we need to either merge in 1.1.3 and then re-do Peters commit or simply:
Further, we should:
The text was updated successfully, but these errors were encountered: