Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required ARIA parent role is not present for the tab items in the page #590

Closed
polatengin opened this issue Jan 10, 2024 · 0 comments · Fixed by #591 or #608
Closed

Required ARIA parent role is not present for the tab items in the page #590

polatengin opened this issue Jan 10, 2024 · 0 comments · Fixed by #591 or #608
Assignees
Labels
bug Something isn't working

Comments

@polatengin
Copy link
Collaborator

Note: Same issue reproes throughout the application.

Impact on a Person with Disability (PWD):
Visually challenged users who rely on screen reader for navigation are facing difficulty as Required ARIA parent role is not present for the tab items in the page.

Test Environment:
OS: Windows 11 [Version 23H2 (OS Build 22631.2715)]
Browser: Edge Version (119.0.2151.97), Chrome Version (119.0.6045.200)
URL: Work items - Boards (visualstudio.com)
Tools: Accessibility insights for web

Repro Steps:
Step 1: Open MCAPS ADO in Edge/Chrome browser.
Step 2: Navigate to 'Retrospective' in left navigation and invoke it.
Step 3: Navigate to the collect tab and invoke it. Run AI.
Step 4: Verify whether required ARIA parent role is present for the tab items in the page or not

Actual Result:
Required ARIA parent role is not present for the tab items in the page.
Current Observation:

  1. When focus lands on the collect tab NVDA is narrating as "Tab selected workflow collect"

Expected Result:
Required ARIA parent role should be present for the tab items in the page.
Ex:

  1. When focus lands on the collect tab NVDA should be narrating as "Tab selected workflow collect list 1 of 4"

Suggestive fix
1.provide 'aria-setsize="4", 'aria-posinset="1"' for
first tab.
2.provide 'aria-setsize="4", 'aria-posinset="2"' for
second tab.
3.provide 'aria-setsize="4", 'aria-posinset="3"' for
third tab.
4.provide 'aria-setsize="4", 'aria-posinset="4"' for
fourth tab.

K4W:
Title: WCAG 1.3.1: Ensures elements with an ARIA role that require parent roles are contained by them (.active)

Tags: Accessibility, WCAG 1.3.1, aria-required-parent

Issue: Ensures elements with an ARIA role that require parent roles are contained by them (aria-required-parent - https://accessibilityinsights.io/info-examples/web/aria-required-parent)

Target application: Retrospectives - Boards - https://worldwidelearning.visualstudio.com/MCAPS%20Accessibility/_apps/hub/ms-devlabs.team-retrospectives.home

Element path: .external-content--iframe;.active

Snippet:

Collect

How to fix:
Required ARIA parent role not present: tablist.

MAS Reference:
MAS 1.3.1 – Info and Relationships

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

AzDO Reference Link:
https://worldwidelearning.visualstudio.com/MCAPS%20Accessibility/_workitems/edit/1713019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant