Warning: Function declared 'noreturn' should not return when using RETURN_IF_FAILED macro in clang

[giuntnic]

Compiling
`
#include "wil\result.h"

volatile bool debug = false;

HRESULT test_func()
{
if(debug)
{
return E_FAIL;
}
return S_OK;
}

int main(void)
{
RETURN_IF_FAILED(test_func());
return 0;
}`

with Clang gives
In file included from ../..\..\wil\result.h:16: ../..\..\wil/result_macros.h(4256,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4262,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4268,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4274,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4288,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4294,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4300,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4306,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4312,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4480,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4488,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4496,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4504,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4520,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4526,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4532,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4538,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4544,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4742,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4748,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4798,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ ../..\..\wil/result_macros.h(4804,13): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ 22 warnings generated.

[metathinker]

It looks like you might have fixed this issue with PR #80 ; is that right?

[giuntnic]

Correct, this should be resolved with that PR.