Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient brushes are created with CanvasEdgeBehavior::Wrap by default #25

Closed
davidni opened this issue Oct 24, 2014 · 0 comments · Fixed by #27
Closed

Gradient brushes are created with CanvasEdgeBehavior::Wrap by default #25

davidni opened this issue Oct 24, 2014 · 0 comments · Fixed by #27

Comments

@davidni
Copy link
Contributor

davidni commented Oct 24, 2014

The CsConsumer Gradients demo uses a radial gradient brush and a linear gradient brush, both of which are created with CanvasEdgeBehavior::Wrap. This causes the edge of the drawn shapes to show an undesirable border (in the case of the circle, a bad-looking dark border; in the case of the rectangle, a thin red line in the purple end).

IMHO using CanvasEdgeBehavior::Clamp by default would make more sense, and I already have a fix that does that in my fork. I'll send a PR shortly.

Here's a screenshot of the circle looking particularly bad:

image

@davidni davidni changed the title Gradient brushed are created with CanvasEdgeBehavior::Wrap by default Gradient brushes are created with CanvasEdgeBehavior::Wrap by default Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant