Feature request: PAUTHZ_CLIENT_CONTEXT_HANDLE in functions should be a pointer or &mut AUTHZ_CLIENT_CONTEXT_HANDLE

[Zerowalker]

Motivation

Prevents having to cast to *const/mut isize and makes it consistent with the functions.

say: https://docs.microsoft.com/en-us/windows/win32/api/authz/nf-authz-authzinitializecontextfromsid
If i am not mistaken it will always give you a AUTHZ_CLIENT_CONTEXT_HANDLE at the out parameter phAuthzClientContext.
And if so it doesn't make much sense for it to be a neutral isize, actually find it weird it's that and not c_void though.
Looking at the metadata it looks like it's seens as a *AUTHZ_CLIENT_CONTEXT_HANDLE.

Drawbacks

If it's not actually not always a &mut/cont AUTHZ_CLIENT_CONTEXT_HANDLE and some other data can be written in the/some functions then the typing will break that.

Rationale and alternatives

The current design makes you able to pass any isize (in a nutshell any HANDLE.0) which makes it "confusing" for no reason.
If it's just a single type, then it's better to just utilize that to make rust do it's thing without extra steps.

Additional context

Current art is kinda like this:

    let mut client_context = AUTHZ_CLIENT_CONTEXT_HANDLE::default();
            unsafe {
                AuthzInitializeContextFromSid(
                    0,
                    ...,
                    ...,
                    null_mut(),
                    LUID::default(),
                    null_mut(),
                    &mut client_context.0,
                )
            }
            .ok().unwrap();

[kennykerr]

The metadata appears to lose the type of its final out parameter:

[DllImport("AUTHZ", ExactSpelling = true, PreserveSig = false, SetLastError = true)]
[SupportedOSPlatform("windows5.1.2600")]
public unsafe static extern BOOL AuthzInitializeContextFromSid([In] uint Flags, [In] PSID UserSid, [In] AUTHZ_RESOURCE_MANAGER_HANDLE hAuthzResourceManager, [Optional][In] LARGE_INTEGER* pExpirationTime, [In] LUID Identifier, [Optional][In] void* DynamicGroupArgs, [Out] IntPtr* phAuthzClientContext);

If I'm not mistaken, the function should just use the handle type as its final out parameter as the original header does:

AUTHZAPI
BOOL
WINAPI
AuthzInitializeContextFromSid(
    _In_      DWORD                         Flags,
    _In_      PSID                          UserSid,
    _In_      AUTHZ_RESOURCE_MANAGER_HANDLE hAuthzResourceManager,
    _In_opt_  PLARGE_INTEGER                pExpirationTime,
    _In_      LUID                          Identifier,
    _In_opt_  PVOID                         DynamicGroupArgs,
    _Out_     PAUTHZ_CLIENT_CONTEXT_HANDLE  phAuthzClientContext
    );

Thanks for reporting! I'll transfer to the win32metadata repo for a fix.

[Zerowalker]

Oh, was looking at the wrong place, probably cause i looked at the type itself (which doesn't exist in Rust),
and it came up in the meta.

Glad i could help.

[mikebattista]

Windows.Win32.Security.Authorization.Apis.AuthzInitializeContextFromToken : phAuthzClientContext...IntPtr* => AUTHZ_CLIENT_CONTEXT_HANDLE*
Windows.Win32.Security.Authorization.Apis.AuthzInitializeContextFromSid : phAuthzClientContext...IntPtr* => AUTHZ_CLIENT_CONTEXT_HANDLE*
Windows.Win32.Security.Authorization.Apis.AuthzInitializeContextFromAuthzContext : phNewAuthzClientContext...IntPtr* => AUTHZ_CLIENT_CONTEXT_HANDLE*
Windows.Win32.Security.Authorization.Apis.AuthzInitializeCompoundContext : phCompoundContext...IntPtr* => AUTHZ_CLIENT_CONTEXT_HANDLE*
Windows.Win32.Security.Authorization.Apis.AuthzAddSidsToContext : phNewAuthzClientContext...IntPtr* => AUTHZ_CLIENT_CONTEXT_HANDLE*