Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU functions should be cdecl #1013

Closed
Berrysoft opened this issue Jul 27, 2022 · 3 comments
Closed

ICU functions should be cdecl #1013

Berrysoft opened this issue Jul 27, 2022 · 3 comments
Labels
broken api An API is inaccurate and could lead to runtime failure

Comments

@Berrysoft
Copy link

The ICU functions provided in Windows.Win32.Globalization should be cdecl, but they are now marked as winapi, aka stdcall.

@riverar
Copy link
Collaborator

riverar commented Jul 28, 2022

// icu.h
#elif defined(_MSC_VER)
#   define U_EXPORT2 __cdecl
...
U_CAPI UChar32 U_EXPORT2
utf8_nextCharSafeBody(const uint8_t *s, int32_t *pi, int32_t length, UChar32 c, UBool strict);

@mikebattista
Copy link
Contributor

I see CallingConvention = CallingConvention.Cdecl inside the DllImport attribute on all these APIs.

Closing out for now. Reactivate if you have more specifics on any requested metadata changes.

@riverar
Copy link
Collaborator

riverar commented Feb 20, 2023

Believe this was fixed with #1201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken api An API is inaccurate and could lead to runtime failure
Projects
None yet
Development

No branches or pull requests

3 participants