Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MainAVIHeader.dwReserved is missing fixed array length annotation #118

Closed
AArnott opened this issue Jan 13, 2021 · 1 comment
Closed

MainAVIHeader.dwReserved is missing fixed array length annotation #118

AArnott opened this issue Jan 13, 2021 · 1 comment
Labels
broken api An API is inaccurate and could lead to runtime failure

Comments

@AArnott
Copy link
Member

AArnott commented Jan 13, 2021

Metadata defines the field as

	public uint[] dwReserved;

But the native definition is

    DWORD		dwReserved[4];

This means the metadata doesn't define the accurate size of the struct, among other things.
@AArnott AArnott mentioned this issue Jan 13, 2021
Closed
@AArnott AArnott added the broken api An API is inaccurate and could lead to runtime failure label Jan 14, 2021
@sotteson1
Copy link
Contributor

This looks right when looking at IL using ILSpy:

.field public uint32[0...3] dwReserved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken api An API is inaccurate and could lead to runtime failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AArnott @sotteson1