Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases for RTL_CONDITION_VARIABLE, RTL_SRWLOCK and RTL_RUN_ONCE #1522

Closed
ChrisDenton opened this issue Apr 4, 2023 · 3 comments
Closed

Add aliases for RTL_CONDITION_VARIABLE, RTL_SRWLOCK and RTL_RUN_ONCE #1522

ChrisDenton opened this issue Apr 4, 2023 · 3 comments
Assignees
@mikebattista

Comments

@ChrisDenton
Copy link
Contributor

Some Win32 types are simply aliases for NT types. Maybe we should preserve that in the metadata? Currently they are only named with their NT name, which is confusing if you're reading the docs (e.g. SleepConditionVariableSRW).

Win32 name NT name
CONDITION_VARIABLE RTL_CONDITION_VARIABLE
SRWLOCK RTL_SRWLOCK
INIT_ONCE RTL_RUN_ONCE
@mikebattista mikebattista self-assigned this Apr 5, 2023
@mikebattista
Copy link
Contributor

Need more details on how this would be represented in the metadata.

@mikebattista
Copy link
Contributor

Related discussion at #1517 (comment).

@mikebattista
Copy link
Contributor

It seems everywhere these are used they are referred to with the Win32 names. Should we just rename the RTL_ structs to remove the prefix?

@mikebattista mikebattista mentioned this issue Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisDenton @mikebattista