Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDL compilation bugs #1571

Closed
mikebattista opened this issue May 9, 2023 · 0 comments
Closed

Fix IDL compilation bugs #1571

mikebattista opened this issue May 9, 2023 · 0 comments
Assignees
Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working

Comments

@mikebattista
Copy link
Contributor

mikebattista commented May 9, 2023

  1. IDL files that don't have corresponding header files are being skipped over when converting MIDL attributes to SAL annotations
  2. Only the first MIDL attribute list is being converted to SAL annotations

Discovered while investigating #1570. strmif.idl includes other idl files whose MIDL attributes weren't being converted to SAL annotations. A few other IDL files follow the same pattern.

While comparing the diff for 1, a handful of APIs lost attributes which appeared to be caused by a bug with how multiple MIDL attribute lists are handled.

@mikebattista mikebattista added bug Something isn't working broken api An API is inaccurate and could lead to runtime failure labels May 9, 2023
@mikebattista mikebattista self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant