Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including machine readable docs for published APIs so that languages can generate code comments #5

Closed
kennykerr opened this issue Oct 19, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@kennykerr
Copy link
Contributor

No description provided.

@kennykerr kennykerr added the enhancement New feature or request label Oct 19, 2020
@sotteson1 sotteson1 added this to the Preview 0.5 - build milestone Nov 11, 2020
@kennykerr
Copy link
Contributor Author

FYI @asklar has been experimenting with doing this for WinRT APIs.

@AArnott
Copy link
Member

AArnott commented Dec 2, 2020

The C# projection uses this tool to scrape docs into YAML for inclusion as xml doc comments in the C#-produced APIs.
It's intended to be shareable. We could move that tool into this repo if that's helpful.

@asklar
Copy link
Member

asklar commented Dec 2, 2020

I think we will want to use the same approach we'll use for cswinrt where we'd use roslyn to turn XML comments into a custom attribute in the winmd, that can be read by any number of tools.

@AArnott
Copy link
Member

AArnott commented Dec 3, 2020

The docs are 50+ MBs, @asklar. I'd rather the metadata dll not be so huge. In fact, I hear that assemblies have a max size (or 10MB?) for how much space can be spent on strings, so it may be technically impossible to put all the docs in the assembly as custom attributes.
I think the docs should remain outside the metadata dll.

@AArnott
Copy link
Member

AArnott commented Dec 8, 2020

Keeping the docs separate from the dll also allows for the possibility of localization where the projection produces docs in the author or project's preferred language rather than always English.

@asklar
Copy link
Member

asklar commented Dec 9, 2020

FWIW localization can be baked into the custom property, just like classic COM did helpstringdll / helpstringcontext (an ID and a DLL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants