Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12CreateDevice requires Win32_Graphics_Direct3D11 #733

Closed
Jasper-Bekkers opened this issue Nov 8, 2021 · 3 comments
Closed

D3D12CreateDevice requires Win32_Graphics_Direct3D11 #733

Jasper-Bekkers opened this issue Nov 8, 2021 · 3 comments

Comments

@Jasper-Bekkers
Copy link

I would've assumed this was a win32metadata issue, but I can't seem to find the cause of this in win32metadata, so posting it here. If it needs to move, let me know.

However it looks like Win32_Graphics_Direct3D11 is required for D3D12CreateDevice because of the D3D_FEATURE_LEVEL enum which is slightly unfortunate (since it's the only thing that seems to require it).

In the regular C++ headers, these enums are defined in d3dcommon.h so they can be shared between versions.

(In looking through this, I also noticed D3D11On12CreateDevice is behind the 12 feature toggle, which seems slightly odd too, I'd expect it to only need 11).

@kennykerr
Copy link
Contributor

Yes, I believe this is a metadata issue. Will transfer.

I think @damyanp and @sotteson1 have done some work to clean this up but they can confirm. As soon as a build is available with their changes I can ingest into the Windows crate.

@kennykerr kennykerr transferred this issue from microsoft/windows-rs Nov 8, 2021
@damyanp
Copy link
Member

damyanp commented Nov 8, 2021

@Jasper-Bekkers - if you were looking at win32metadata after #579 was merged then you should see that this problem has been resolved - this PR was intended to solve exactly these sorts of problems.

@kennykerr
Copy link
Contributor

It doesn't look like there's a release that includes that PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants