Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement and interface macros will soon be on stable #1523

Closed
kennykerr opened this issue Feb 10, 2022 · 7 comments
Closed

implement and interface macros will soon be on stable #1523

kennykerr opened this issue Feb 10, 2022 · 7 comments

Comments

@kennykerr
Copy link
Collaborator

kennykerr commented Feb 10, 2022

@eholk recently completed the work to stabilize the const_fn_fn_ptr_basics and const_fn_trait_bound Rust features:

rust-lang/rust#93827

These features will become stable as of Rust 1.61. These features are required by the windows crate's implement and interface macros. If you use these macros with an earlier version of Rust, you will need to use a nightly compiler.

@mwcampbell
Copy link

Just to make sure I understand correctly, is it a known issue right now that the "implement" feature in the current version of windows-rs requires a nightly toolchain? If so, do you know what the timeframe for resolving this is? In the meantime, we can keep using a previous version of windows-rs.

@kennykerr
Copy link
Collaborator Author

That's right, stabilization has now been approved. I think this means it should show up in the next stable release.

@eholk
Copy link
Collaborator

eholk commented Mar 4, 2022

Once the PR merges, which should be soon, the features will become stable in 1.61. It's technically two stable releases away since 1.60 is in beta right now.

@kennykerr
Copy link
Collaborator Author

#1591 removed these features. Now we just need 1.61 to be released, but there is no more work for the windows crate so I'm closing this issue.

@kennykerr
Copy link
Collaborator Author

This is now published as part of 0.34.0.

@kennykerr kennykerr changed the title const_fn_fn_ptr_basics and const_fn_trait_bound will soon be stable implement and interface macros will soon be stable Mar 18, 2022
@kennykerr kennykerr pinned this issue Mar 18, 2022
@kennykerr kennykerr changed the title implement and interface macros will soon be stable implement and interface macros available on stable as of Rust 1.61 Mar 18, 2022
@kennykerr kennykerr changed the title implement and interface macros available on stable as of Rust 1.61 implement and interface macros will soon be stable Mar 18, 2022
@kennykerr kennykerr changed the title implement and interface macros will soon be stable implement and interface macros will soon be available on stable Mar 18, 2022
@kennykerr kennykerr changed the title implement and interface macros will soon be available on stable implement and interface macros will soon be on stable Mar 18, 2022
@kennykerr kennykerr unpinned this issue May 19, 2022
@harryjph
Copy link

FAQ.md needs to be updated to reflect that nightly is no longer required.

@kennykerr
Copy link
Collaborator Author

Thanks for the reminder! #1929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants