Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version should be included in the User-Agent header #48

Closed
WilliamsJason opened this issue Jul 13, 2016 · 4 comments
Closed

Version should be included in the User-Agent header #48

WilliamsJason opened this issue Jul 13, 2016 · 4 comments
Assignees
Labels

Comments

@WilliamsJason
Copy link
Contributor

Right now we can't determine anything about the version of WDPW which is calling WDP from the User-Agent header. We should get information added which will help out here.

One thing to keep in mind is that people forking the project, etc can complicate this beyond 'official released versions'.

@david-c-kline
Copy link

Not sure we can enforce a version scheme here since this is open and the version may jump or stay static. That said, I am willing to have one :)

@david-c-kline david-c-kline self-assigned this Jul 25, 2016
@david-c-kline
Copy link

assigning to me. I have a fix

@WilliamsJason
Copy link
Contributor Author

I also think it would be nice if we come up with a plan to distinguish between uses of the NuGet package (unchanged DLL) and privately built versions of the DLL (of which we can't really make judgements about the version since the private fork could be modified as much as they want). Seems like the version schema we develop could capture that information.

@david-c-kline
Copy link

fixed with #72. We will determine a special annotation for the NuGet package as we prepare that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants