Upgrade doesn't work for Microsoft.VisualStudio.2019.BuildTools

[joelsgp]

Brief description of your issue

I have Visual Studio Build Tools 2019 installed. When I try to use winget to upgrade it, it updates the Visual Studio Installer, but does not affect the Build Tools themselves, and after a 'successful' upgrade, it will still beileve they need upgrading.

Steps to reproduce

1. Install Visual Studio Build Tools 2019 through the Visual Studio Installer
2. winget upgrade Microsoft.VisualStudio.2019.BuildTools (or winget upgrade --all)
3. winget upgrade Microsoft.VisualStudio.2019.BuildTools again and you will see it was unsuccessful

Expected behavior

Build tools will be upgraded successfully, and running the command again will return No applicable update found.

Actual behavior

Build tools are not upgraded, running the command again does the same thing over and over again

Environment

Windows Package Manager v1.0.11692
Windows: Windows.Desktop v10.0.19043.1149
Package: Microsoft.DesktopAppInstaller v1.12.11692.0

Any other software?

Microsoft.VisualStudio.2019.BuildTools 16.10.3

[joelsgp]

Visual Studio Installer version 2.11.13.53049

[joelsgp]

Updated build tools in the vs installer, same deal

Microsoft Windows [Version 10.0.19043.1149]
(c) Microsoft Corporation. All rights reserved.

C:\Users\joelm>winget list build
Name                           Id                                     Version Available       Source
----------------------------------------------------------------------------------------------------
Visual Studio Build Tools 2019 Microsoft.VisualStudio.2019.BuildTools 16.10.4 16.10.31515.178 winget

C:\Users\joelm>winget upgrade Microsoft.VisualStudio.2019.BuildTools
Found Visual Studio Build Tools 2019 [Microsoft.VisualStudio.2019.BuildTools]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/acfc792d-506b-4868-9924-aeedc61ae654/1778d923fd40c62c29f85cf4ef63a0c855a61c13b1dd68419bcda2cff38c984f/vs_BuildTools.exe
  ██████████████████████████████  1.39 MB / 1.39 MB
Successfully verified installer hash
Starting package install...
Successfully installed

C:\Users\joelm>winget upgrade Microsoft.VisualStudio.2019.BuildTools
Found Visual Studio Build Tools 2019 [Microsoft.VisualStudio.2019.BuildTools]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/acfc792d-506b-4868-9924-aeedc61ae654/1778d923fd40c62c29f85cf4ef63a0c855a61c13b1dd68419bcda2cff38c984f/vs_BuildTools.exe
  ██████████████████████████████  1.39 MB / 1.39 MB
Successfully verified installer hash
Starting package install...
Successfully installed

C:\Users\joelm>

[jedieaston]

It's because 16.10.31515.178 is 16.10.4, and we're using the build numbers instead of the real version number as listed in the Add and Remove Programs table because the Visual Studio team made a change to their versioning (they used to always use the build number, now they use the shorter number for some reason). We can't set it to the "real version number" since winget will think that the older versions with the larger build numbers are newer than the actual new versions with the smaller version numbers.

We're waiting for clarification on from the VS team that this was an intentional change, and if that is the case I'll probably just set the old versions of Visual Studio to use their smaller build numbers, even if they won't match with their ARP table entries anymore. See microsoft/winget-pkgs#19389 for more info.

TL;DR: Our metadata is wrong, you aren't getting an upgrade because you are up-to-date.

[KevinLaMS]

I will follow up on the VS issue.

[jedieaston]

Looks like the lion's share of the metadata fixes have been merged into microsoft/winget-pkgs:

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list
Name                                    Id                                            Version          Available   Source
-------------------------------------------------------------------------------------------------------------------------
Visual Studio Build Tools 2019          Microsoft.VisualStudio.2019.BuildTools        16.10.4
Microsoft Edge                          Microsoft.Edge                                90.0.818.66      92.0.902.55 winget
Microsoft Edge Update                   Microsoft Edge Update                         1.3.143.57
App Installer                           Microsoft.DesktopAppInstaller_8wekyb3d8bbwe   1.12.11692.0
Microsoft Edge                          Microsoft.MicrosoftEdge.Stable_8wekyb3d8bbwe  90.0.818.66
Windows Security                        Microsoft.SecHealthUI_8wekyb3d8bbwe           1000.22000.1.0
WinGet MSStore Source                   Microsoft.Winget.MSStore.Source_8wekyb3d8bbwe 2021.328.455.669
Windows Package Manager Source (winget) Microsoft.Winget.Source_8wekyb3d8bbwe         2021.729.308.624
Microsoft Visual Studio Installer       {6F320B93-EE3C-4826-85E0-ADF79F8D4C61}        2.11.13.53049
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade Microsoft.VisualStudio.2019.BuildTools
No applicable update found.
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs>

Can you check again and see if it still wants you to upgrade?

[joelsgp]

Fixed, thanks 👍

Microsoft Windows [Version 10.0.19043.1149]
(c) Microsoft Corporation. All rights reserved.

C:\Users\joelm>winget list build
Name                           Id                                     Version
-----------------------------------------------------------------------------
Visual Studio Build Tools 2019 Microsoft.VisualStudio.2019.BuildTools 16.10.4

C:\Users\joelm>