Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget upgrade --all fails for all packages even if only one single package causes error #1442

Closed
siddagra opened this issue Sep 8, 2021 · 17 comments · Fixed by #2089
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@siddagra
Copy link

siddagra commented Sep 8, 2021

Brief description of your issue

If a single app fails to install in winget upgrade --all, it will close the entire upgrade sequence. Leaving all following apps unupgraded. Instead, it should upgrade all apps and ignore upgrading the apps for which an error occurs.

Steps to reproduce

I Installed kite from vscode installer. Microsoft is unable to download the package/setup.exe and fails. It then does not proceed to upgrade/update any of my other apps:
image

Expected behavior

Winget should try to upgrade all apps and ignore upgrading the apps for which an error occurs.

Actual behavior

If a single app fails to install in winget upgrade --all, it will close the entire upgrade sequence. Leaving all following apps unupgraded.

Environment

[winget --info]
Windows Package Manager version: v1.0.11694
Windows: Windows 11
Package: App Installer                           Microsoft.DesktopAppInstaller_8wekyb3d8… 1.15.11694.0

Any other software?
@ghost ghost added the Needs-Triage Issue need to be triaged label Sep 8, 2021
@siddagra siddagra changed the title winget upgrade --all fails if a single package cant be found winget upgrade --all fails for all packages if a single package causes error Sep 8, 2021
@siddagra siddagra changed the title winget upgrade --all fails for all packages if a single package causes error winget upgrade --all fails for all packages even if only one single package causes error Sep 8, 2021
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Sep 8, 2021
@denelon denelon added this to To do in Client-Current via automation Oct 1, 2021
@denelon denelon added this to To Do in Client-Bugs via automation Oct 1, 2021
@denelon denelon added this to the v1.2-Client milestone Oct 1, 2021
@denelon denelon modified the milestones: v1.2-Client, v1.3-Client Jan 8, 2022
@sba923
Copy link

sba923 commented Mar 11, 2022

I concur.

Just experienced the same thing:

PS❯  winget upgrade
Name                                            Id                            Version        Available       Source
-------------------------------------------------------------------------------------------------------------------
Discord                                         Discord.Discord               1.0.9001       1.0.9004        winget
Microsoft Visual C++ 2008 Redistributable - x86 Microsoft.VC++2008Redist-x86  9.0.30729.4148 9.0.30729.6161  winget
Microsoft Windows Desktop Runtime - 5 (x86)     Microsoft.dotnetRuntime.5-x86 5.0.14.30911   5.0.15.31016    winget
GOG GALAXY                                      GOG.Galaxy                    Unknown        2.0.46.133      winget
Graphviz                                        Graphviz.Graphviz             2.38           2.50.0          winget
calibre                                         calibre.calibre               5.37.0         5.38.0          winget
Python 2                                        Python.Python.2               2.7.16150      2.7.18150       winget
VNC Viewer                                      RealVNC.VNCViewer             6.20.529.42646 6.21.1109.45988 winget
Go Programming Language                         GoLang.Go                     1.17.7         1.17.8          winget
Microsoft Visual Studio Code                    Microsoft.VisualStudioCode    1.64.2         1.65.2          winget
Microsoft .NET SDK                              Microsoft.dotnet              5.3.321.37723  6.1.322.12413   winget
Microsoft Windows Desktop Runtime - 5 (x64)     Microsoft.dotnetRuntime.5-x64 5.0.14.30911   5.0.15.31016    winget
Windows Assessment and Deployment Kit           Microsoft.WindowsADK          10.1.17134.1   10.1.22000.1    winget
Microsoft Windows Desktop Runtime - 6 (x86)     Microsoft.dotnetRuntime.6-x86 6.0.2.30914    6.0.3.31024     winget
14 upgrades available.
PS❯  winget upgrade --all
An unexpected error occurred while executing the command:
InternetOpenUrl() failed.
0x80072efd : unknown error

FWIW, here's my workaround:

PS❯  winget upgrade | ConvertFrom-WingetStdout.ps1 | % { $_.Name; $_.Id; winget upgrade --id $_.Id }

using ConvertFrom-WingetStdout.ps1.

@denelon
Copy link
Contributor

denelon commented Mar 11, 2022

@siddagra

I believe this has been resolved in a prior release. Can you confirm?

@denelon denelon added the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 11, 2022
@JSkimming
Copy link

@siddagra A single error is still preventing me from upgrading all

winget upgrade --all
Found Graphviz [Graphviz.Graphviz] Version 2.50.0
Found OpenSSL Light [ShiningLight.OpenSSL.Light] Version 1.0.0
Found VLC media player [VideoLAN.VLC] Version 3.0.17
Found pgAdmin 4 [PostgreSQL.pgAdmin] Version 6.5
Found Node.js [OpenJS.NodeJS] Version 17.7.1
Found Microsoft .NET SDK [Microsoft.dotnet] Version 6.1.322.12413
Found Microsoft Windows Desktop Runtime - 3 (x64) [Microsoft.dotnetRuntime.3-x64] Version 3.1.23.31022
Found Jabra Direct [Jabra.Direct] Version 5.12.6601
Found Python 3 [Python.Python.3] Version 3.10.2150.0
Found GitHub CLI [GitHub.cli] Version 2.6.0
Found Microsoft SQL Server Management Studio [Microsoft.SQLServerManagementStudio] Version 15.0.18410.0
(1/11) Found Graphviz [Graphviz.Graphviz] Version 2.50.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://gitlab.com/api/v4/projects/4207231/packages/generic/graphviz-releases/2.50.0/windows_10_cmake_Release_graphviz-install-2.50.0-win64.exe
  ██████████████████████████████  4.48 MB / 4.48 MB
Successfully verified installer hash
Starting package install...
Successfully installed

(2/11) Found OpenSSL Light [ShiningLight.OpenSSL.Light] Version 1.0.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://slproweb.com/download/Win64OpenSSL_Light-1_1_1m.exe
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190194 : Not found (404).

@sba923
Copy link

sba923 commented Mar 18, 2022

Related issue: if one of the updates is canceled (e.g. at a UAC prompt) the operation does not continue with the next update.

@psychelzh
Copy link

psychelzh commented Mar 21, 2022

@denelon This has not been solved.

winget upgrade --all
已找到 全球学术快报 [TTKN.CNKIExpress] 版本 0.1.19
已找到 Node.js [OpenJS.NodeJS] 版本 17.7.2
已找到 Microsoft .NET SDK [Microsoft.dotnet] 版本 6.1.322.12413
已找到 Telegram Desktop [Telegram.TelegramDesktop] 版本 3.6.1
已找到 calibre [calibre.calibre] 版本 5.39.1
已找到 GitHub CLI [GitHub.cli] 版本 2.6.0
已找到 Python 3 [Python.Python.3] 版本 3.10.3150.0
已找到 网易云音乐 [NetEase.CloudMusic] 版本 2.9.8.199759
已找到 钉钉 [Alibaba.DingTalk] 版本 6.3.35-Release.3179104
(1/9) 已找到 全球学术快报 [TTKN.CNKIExpress] 版本 0.1.19
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责,也不向第三方程序包授予任何许可证。
Downloading https://download.cnki.net/cnkiexpress/%E5%85%A8%E7%90%83%E5%AD%A6%E6%9C%AF%E5%BF%AB%E6%8A%A5%20Setup%200.1.19.exe
执行此命令时发生意外错误:
Download request status is not success.
0x80190194 : δ�ҵ�(404)��

@ghost ghost added the No-Recent-Activity Issue has no recent activity label Mar 28, 2022
@ghost
Copy link

ghost commented Mar 28, 2022

@siddagra this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@JSkimming
Copy link

Several people have replied with feedback, can we remove the Needs-Author-Feedback label?

@ghost ghost removed the No-Recent-Activity Issue has no recent activity label Mar 28, 2022
@denelon
Copy link
Contributor

denelon commented Mar 28, 2022

@JSkimming, the author reported this with the 1.0 release. This was corrected in a previous release. I've been able to cause a failure in one of the packages during winget upgrade -all and had the remaining installations continue. I believe this is resolved. None of the additional reports are showing which version of the Windows Package Manager they are using.

@JSkimming
Copy link

JSkimming commented Mar 28, 2022

@denelon I can confirm that winget upgrade --all fails to continue after this particular failure on version v1.2.10271.

Please ignore this comment I realized there was only one package to update.

But my earlier comment was only 10 days ago and was probably v1.2.10271.

@sba923
Copy link

sba923 commented Mar 28, 2022

Related issue: if one of the updates is canceled (e.g. at a UAC prompt) the operation does not continue with the next update.

I have reproduced this with 1.2

@denelon
Copy link
Contributor

denelon commented Mar 28, 2022

@JSkimming Teams is known to be problematic with the system wide installer. We have other issues tracking that. I believe what was reported is when there are multiple upgrades, and one of them fails, the other upgrades don't even run.

There are still several challenges with upgrading individual applications, and we have several bugs open for those. This bug was specifically calling out the failure for winget upgrade --all to continue with the other packages after a single failure.

@denelon
Copy link
Contributor

denelon commented Mar 28, 2022

@sba923 I'll look into that scenario. Do you know which package had the UAC you cancelled? I'll set up a test to verify that situation.

@sba923
Copy link

sba923 commented Mar 28, 2022

@sba923 I'll look into that scenario. Do you know which package had the UAC you cancelled? I'll set up a test to verify that situation.

Not from the top of my head. Will refrain from running winget from an elevated PowerShell prompt for a while, this should trigger a repro quite easily.

@ghost ghost added the No-Recent-Activity Issue has no recent activity label Apr 4, 2022
@ghost
Copy link

ghost commented Apr 4, 2022

@siddagra this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@psychelzh
Copy link

Confirmed with v1.3:

winget upgrade --all
名称                                ID                             版本                  可用                  源
---------------------------------------------------------------------------------------------------------------------
PDFlux                              PaodingAI.PDFlux               5.0.19                5.0.24                winget
draw.io                             JGraph.Draw                    17.2.1                17.2.4                winget
阿里云盘                            Alibaba.aDrive                 3.0.0                 3.1.1                 winget
FileZilla Client                    TimKosse.FileZilla.Client      3.58.0                3.59.0                winget
Microsoft Edge                      Microsoft.Edge                 100.0.1185.36         100.0.1185.39         winget
RStudio Desktop Open Source Edition RStudio.RStudio.OpenSource     2022.02.0+443         2022.02.1+461         winget
Tencent Meeting                     Tencent.TencentMeeting         3.6.5.404             3.6.7.428             winget
Zotero                              Zotero.Zotero                  6.0.3                 6.0.4                 winget
全球学术快报                        TTKN.CNKIExpress               0.1.19                0.1.20                winget
Free Download Manager               SoftDeluxe.FreeDownloadManager 6.16.0.4468           6.16.1.4558           winget
Microsoft .NET SDK                  Microsoft.dotnet               5.4.522.6820          6.1.322.12413         winget
Microsoft .NET SDK                  Microsoft.dotnet               5.4.622.11901         6.1.322.12413         winget
Node.js                             OpenJS.NodeJS                  17.8.0                17.9.0                winget
GitHub CLI                          GitHub.cli                     2.6.0                 2.7.0                 winget
calibre                             calibre.calibre                5.39.1                5.40.0                winget
Microsoft Visual Studio Code        Microsoft.VisualStudioCode     1.65.2                1.66.1                winget
Microsoft .NET SDK                  Microsoft.dotnet               5.3.321.37723         6.1.322.12413         winget
百度网盘                            Baidu.BaiduNetdisk             7.13.0                7.14.1                winget
DingTalk                            Alibaba.DingTalk               6.5.0-Release.3249116 6.5.0-Release.3289101 winget
20 升级可用。
1 package has a version number that cannot be determined. Use "--include-unknown" to see all results.

(1/17) 已找到 PDFlux [PaodingAI.PDFlux] 版本 5.0.24
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责,也不向第三方程序包授予任何许可证。
Downloading https://pdflux.com/downloads/PDFlux-5.0.24-win-x64.exe
  ██████████████████████████████  74.8 MB / 74.8 MB
已成功验证安装程序哈希
正在启动程序包安装...
已成功安装

(2/17) 已找到 draw.io [JGraph.Draw] 版本 17.2.4
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责,也不向第三方程序包授予任何许可证。
Downloading https://github.com/jgraph/drawio-desktop/releases/download/v17.2.4/draw.io-17.2.4-windows-installer.exe
  ██████████████████████████████  0.00 B / 78.2 MB
执行此命令时发生意外错误:
InternetOpenUrl() failed.
0x80072efd : unknown error

Version info:

winget --version
v1.3.692-preview

@ghost ghost removed the No-Recent-Activity Issue has no recent activity label Apr 12, 2022
@denelon denelon removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 12, 2022
@ghost ghost added the In-PR Issue related to a PR label Apr 12, 2022
Client-Bugs automation moved this from To Do to Done Apr 12, 2022
Client-Current automation moved this from To do to Done Apr 12, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Apr 12, 2022
@denelon denelon moved this from Done to Released in Client-Current Jul 11, 2022
@frederickjjoubert
Copy link

Any update on this? It's still happening:

PS C:\Windows\system32> winget upgrade --all
Name                                             Id                                    Version    Available Source
------------------------------------------------------------------------------------------------------------------
Visual Studio Community 2022                     Microsoft.VisualStudio.2022.Community 17.5.0     17.6.2    winget
Mozilla Firefox (x64 en-US)                      Mozilla.Firefox                       112.0      113.0.2   winget
OBS Studio                                       OBSProject.OBSStudio                  29.0.2     29.1.2    winget
TeamViewer                                       TeamViewer.TeamViewer                 15.39.5    15.42.6   winget
qBittorrent                                      qBittorrent.qBittorrent               4.5.1      4.5.2     winget
AOMEI Partition Assistant 9.14.0                 AOMEI.PartitionAssistant              9.14.0     10.0.0    winget
Microsoft Windows Desktop Runtime - 7.0.3 (x64)  Microsoft.DotNet.DesktopRuntime.7     7.0.3      7.0.5     winget
JetBrains ETW Host Service (x64)                 JetBrains.ReSharper                   > 2022.2.2 2022.3.3  winget
Microsoft .NET SDK 5.0.400 (x64)                 Microsoft.DotNet.SDK.7                < 7.0.100  7.0.302   winget
Microsoft .NET SDK 7.0.200 (x64)                 Microsoft.DotNet.SDK.7                7.0.200    7.0.302   winget
Microsoft Windows Desktop Runtime - 6.0.14 (x64) Microsoft.DotNet.DesktopRuntime.6     6.0.14     6.0.16    winget
11 upgrades available.
1 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190194 : Not found (404).

@fekoch
Copy link

fekoch commented Aug 13, 2023

Yeah, I also experience this issue with v1.6.1573-preview:

PS C:\WINDOWS\system32> winget upgrade -r
Name                                             Id                                     Version        Available      Source
----------------------------------------------------------------------------------------------------------------------------
Visual Studio Build Tools 2022                   Microsoft.VisualStudio.2022.BuildTools 17.6.4         17.6.5         winget
Google Chrome                                    Google.Chrome                          111.0.5563.148 114.0.5735.199 winget
maxima-5.41.0                                    MaximaTeam.Maxima                      5.41.0         5.46.0         winget
Maxima computer algebra system                   MaximaTeam.Maxima                      5.45.1         5.46.0         winget
Microsoft XNA Framework Redistributable 4.0      Microsoft.XNARedist                    4.0.20823.0    4.0.30901.0    winget
Webex                                            Cisco.WebexTeams                       42.11.0.24187  43.6.0.26407   winget
Microsoft Windows Desktop Runtime - 6.0.19 (x64) Microsoft.DotNet.DesktopRuntime.6      6.0.19         6.0.20         winget
Epic Games Launcher                              EpicGames.EpicGamesLauncher            1.3.67.0       1.3.78.0       winget
SharpKeys                                        RandyRants.SharpKeys                   3.9.0000       3.9.4000       winget
Eclipse Temurin JDK mit Hotspot 17.0.5+8 (x64)   EclipseAdoptium.Temurin.17.JDK         17.0.5.8       17.0.7.7       winget
Microsoft Windows Desktop Runtime - 7.0.8 (x64)  Microsoft.DotNet.DesktopRuntime.7      7.0.8          7.0.9          winget
13 upgrades available.

The following packages have an upgrade available, but require explicit targeting for upgrade:
Name                         Id              Version      Available   Source
----------------------------------------------------------------------------
Microsoft Teams              Microsoft.Teams 1.3.00.12058 1.6.00.6754 winget
Teams Machine-Wide Installer Microsoft.Teams 1.3.0.362    1.6.00.6754 winget
2 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
An unexpected error occurred while executing the command:
0x80190194 : Not found (404).
winget info
PS C:\WINDOWS\system32> winget --info
Windows Package Manager (Preview) v1.6.1573-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.23521.1000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.1573.0

Winget Directories

Logs %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User) %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User) %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root C:\Program Files\WinGet\Packages
Portable Package Root (x86) C:\Program Files (x86)\WinGet\Packages

Links

Privacy Statement https://aka.ms/winget-privacy
License Agreement https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting State

LocalManifestFiles Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride Disabled
LocalArchiveMalwareScanOverride Disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
Development

Successfully merging a pull request may close this issue.

7 participants