list requires accepting package source's license agreement

[bgribaudo]

Brief description of your issue

On a brand new install of winget (really an auto-install, due to the recent push deploy rollout of the app), running winget list strangly prompts to accept msstore terms. Since list outputs what's installed on my system, it seems strange for it to prompt about something related to an external source.

Steps to reproduce

winget list

Expected behavior

List of installed applications should be displayed.

Actual behavior

PS> winget list
The `msstore` source requires that you view the following agreements before using.
Terms of Transaction: https://aka.ms/microsoft-store-terms-of-transaction
The source requires current machine's geographic region to be sent to function properly.

Do you agree to all the source agreements terms?
[Y] Yes  [N] No: n
One or more of the source agreements were not agreed to. Operation cancelled. Please accept the source agreements or remove the corresponding sources.

It's unexpected (and seems inappropriate) for the request to list locally installed packages to require accepting an external source's terms. Why is an external source involved at all when displaying details from my local environment? Shouldn't msstore agreement acceptance only be required when installing or searching/viewing package info from a source? :-)

Environment

Windows: Windows.Desktop v10.0.19043.1237
Package: Microsoft.DesktopAppInstaller v1.16.12653.0

Thank you!

[denelon]

This is intended behavior.

We've temporarily disabled displaying Apps in list from the "msstore" source ¹, but we still query all sources when we execute the list command. The source agreement is required by the source before gaining access to the manifests. There are several packages from the store like the App Installer (which is how the Windows Package Manager is delivered).

Once the terms are agreed to for the source, you will not get prompted again (unless the agreements change). We do have --accept-source-agreements and --accept-package-agreements available as switches to provide consent and avoid the interactive prompts.

You may also winget remove source msstore from an elevated prompt if you do not wish to have the store source enabled. Running winget source reset --force from an elevated prompt will restore it. Group Policy will be honored however, so you may not be able to add or remove sources if your IT administrator configured the Windows Package Manager with required sources or blocked sources.

Footnotes

1. The matching logic isn't quite right in the "msstore" source yet. We're working on improvements. Due to this we disabled the list output from the source so you don't have bad matches. That also affects export as it depends on list. ↩

[User198263321]

How to I opt-out again to revert that agreement config back to where it was previously? (Where it would ask me to agree to the terms again) @denelon

[JohnMcPMS]

winget source reset should do it, although that may impact other configuration you have. You can also winget source remove msstore if you don't want to agree any more.

winget source reset msstore should theoretically work as well, but looking at things to answer your question I think there is a bug. So I also opened #1575