Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget upgrade should have the option to hide packages with Unknown version from output #1692

Closed
MrBeeMovie opened this issue Nov 10, 2021 · 9 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client. msstore Issue related to "msstore" REST source
Milestone

Comments

@MrBeeMovie
Copy link

Description of the new feature / enhancement

winget upgrade currently shows packages with a version of Unknown as being out of date. Since the version is Unknown the package may or may not be out of date. It would be useful to have the option to hide packages with an Unknown version or allow for the option to list only unknown packages with the upgrade command defaulting to not showing these Unknown version packages.

Proposed technical implementation details

No suggestion.

@MrBeeMovie MrBeeMovie added the Issue-Feature This is a feature request for the Windows Package Manager client. label Nov 10, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Nov 10, 2021
@denelon denelon added msstore Issue related to "msstore" REST source and removed Needs-Triage Issue need to be triaged labels Nov 10, 2021
@jedieaston
Copy link
Contributor

Maybe this should just be a argument, --include-unknown, which enables unknown packages to be upgraded? By default if winget upgrade finds a installed app that doesn't publish version info to the ARP table it won't attempt an upgrade.

Wouldn't be too hard to implement if there's agreement.

@MrBeeMovie
Copy link
Author

Maybe this should just be a argument, --include-unknown, which enables unknown packages to be upgraded? By default if winget upgrade finds a installed app that doesn't publish version info to the ARP table it won't attempt an upgrade.

Wouldn't be too hard to implement if there's agreement.

I would be fine with this solution.

@felipecrs
Copy link
Contributor

I even think that by default such packages should be ignored on winget upgrade --all, but still shown on winget upgrade so that the user is at least aware of it.

@jedieaston
Copy link
Contributor

Perhaps a setting? I would (personally) prefer winget not to show unknown version apps in the upgrade table by default, since 99/100 times "Unknown" ends up meaning "It updates itself", but I can understand that some people may think differently.

It also may be a confusing user experience for a app to be listed for upgrade, then when the user wants to upgrade it and runs winget upgrade --all as they usually would, it doesn't get upgraded since they didn't pass the additional option. A setting that tells winget to use the current behavior (when in doubt, upgrade) that is enforced for both flows would make a little more sense to me.

@MrBeeMovie
Copy link
Author

I even think that by default such packages should be ignored on winget upgrade --all, but still shown on winget upgrade so that the user is at least aware of it.

I disagree since the point of winget upgrade is to see a list of packages that have available updates. If the version is "Unknown" it is not certain whether it has an available update or not. In regards to whether or not the user should be aware, they can use the --include-unknown flag mentioned by @jedieaston if they wish to know about these packages.

@felipecrs
Copy link
Contributor

felipecrs commented Nov 29, 2021

I mean like a new column:

$ winget upgrade
Name         Id            Version Available  Source Auto-update   
----------------------------------------------------------
balenaEtcher Balena.Etcher 1.7.0   1.7.1      winget true
GOG GALAXY   GOG.Galaxy    Unknown 2.0.43.71a winget false

Then:

$ winget upgrade --all
Found balenaEtcher [Balena.Etcher] Version 1.7.1
[...]

@felipecrs
Copy link
Contributor

felipecrs commented Nov 29, 2021

--include-unknown

It's cool for me too.

@jedieaston
Copy link
Contributor

--include-unknown is now in the initial 1.3 preview, available in GitHub Releases:

PS C:\Windows\system32> winget install WinDirStat
Found WinDirStat [WinDirStat.WinDirStat] Version 1.1.2
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://sourceforge.net/projects/windirstat/files/windirstat/1.1.2%20installer%20re-release%20%28more%20languages%21%29/windirstat1_1_2_setup.exe/download
  ██████████████████████████████   630 KB /  630 KB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Windows\system32> winget upgrade
Name           Id              Version     Available    Source
--------------------------------------------------------------
Microsoft Edge Microsoft.Edge  92.0.902.67 98.0.1108.50 winget
calibre        calibre.calibre 4.16.0      5.36.0       winget
2 upgrades available.
1 package has a version number that cannot be determined. Use "--include-unknown" to see all results.
PS C:\Windows\system32> winget upgrade --include-unknown
Name           Id                    Version     Available    Source
--------------------------------------------------------------------
Microsoft Edge Microsoft.Edge        92.0.902.67 98.0.1108.50 winget
WinDirStat     WinDirStat.WinDirStat Unknown     1.1.2        winget
calibre        calibre.calibre       4.16.0      5.36.0       winget
3 upgrades available.
PS C:\Windows\system32>

Do you feel like this resolves the issue, or do we still need a setting?

@MrBeeMovie
Copy link
Author

--include-unknown is now in the initial 1.3 preview, available in GitHub Releases:

PS C:\Windows\system32> winget install WinDirStat
Found WinDirStat [WinDirStat.WinDirStat] Version 1.1.2
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://sourceforge.net/projects/windirstat/files/windirstat/1.1.2%20installer%20re-release%20%28more%20languages%21%29/windirstat1_1_2_setup.exe/download
  ██████████████████████████████   630 KB /  630 KB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Windows\system32> winget upgrade
Name           Id              Version     Available    Source
--------------------------------------------------------------
Microsoft Edge Microsoft.Edge  92.0.902.67 98.0.1108.50 winget
calibre        calibre.calibre 4.16.0      5.36.0       winget
2 upgrades available.
1 package has a version number that cannot be determined. Use "--include-unknown" to see all results.
PS C:\Windows\system32> winget upgrade --include-unknown
Name           Id                    Version     Available    Source
--------------------------------------------------------------------
Microsoft Edge Microsoft.Edge        92.0.902.67 98.0.1108.50 winget
WinDirStat     WinDirStat.WinDirStat Unknown     1.1.2        winget
calibre        calibre.calibre       4.16.0      5.36.0       winget
3 upgrades available.
PS C:\Windows\system32>

Do you feel like this resolves the issue, or do we still need a setting?

This is great!!! Thank you! You guys are doing amazing work!!!!

@denelon denelon added this to the v1.3-Client milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client. msstore Issue related to "msstore" REST source
Projects
None yet
Development

No branches or pull requests

4 participants