Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program names seem to be case sensitive #252

Closed
IngoBoe opened this issue May 20, 2020 · 14 comments · Fixed by #459
Closed

Program names seem to be case sensitive #252

IngoBoe opened this issue May 20, 2020 · 14 comments · Fixed by #459
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@IngoBoe
Copy link

IngoBoe commented May 20, 2020

Brief description of your issue

It is possible to upload program manifests that include names that are case sensitive.

Steps to reproduce

Run
winget install gimp

Expected behavior

Latest version of Gimp is being installed.

Actual behavior

Multiple apps found matching input criteria. Please refine the input.
Name Id        Version Matched
------------------------------------
GIMP Gimp.Gimp 2.10.0  Moniker: gimp
GIMP gimp.gimp 2.10.18 Moniker: gimp

Environment

Windows: Windows.Desktop v10.0.19628.1
Package: Microsoft.DesktopAppInstaller v1.0.41331.0

@denelon denelon added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 20, 2020
@jdhitsolutions
Copy link

I found that I had to use syntax like this:

winget show -e gimp.gimp

And despite what the help says, I could never use the --version switch.

@IngoBoe
Copy link
Author

IngoBoe commented May 20, 2020

Yes, --version seems not to help.

PS C:\Users\ingo> winget install gimp --version 2.10.18
Multiple apps found matching input criteria. Please refine the input.
Name Id        Version Matched
------------------------------------
GIMP Gimp.Gimp 2.10.0  Moniker: gimp
GIMP gimp.gimp 2.10.18 Moniker: gimp

@denelon
Copy link
Contributor

denelon commented May 20, 2020

I see the confusion here. We need to do a better job with examples and possibly commands/syntax. The current behavior 0.1.41331 has -v or --version as a "command" to tell you what version of the winget client is installed, and an "option" to specify a version of a package.

winget --version"`v0.1.41331 Preview'"

'winget show git.git --version 2.25.1` Shows some metadata for the specified version of the manifest

winget install git.git -v 2.24.1.2 installs the specified version of git

In the "install" command, the same --version or -v does something different.

@IngoBoe
Copy link
Author

IngoBoe commented May 20, 2020

Okay, but in this issue -v doesn't work either.

PS C:\Users\ingo> winget install gimp.gimp -v 2.10.18
Multiple apps found matching input criteria. Please refine the input.
Name Id        Version
----------------------
GIMP gimp.gimp 2.10.18
GIMP Gimp.Gimp 2.10.0

@cwoolum
Copy link

cwoolum commented May 20, 2020

It's not possible to specify an id in this case either

PS C:\Users\Chris> winget install --id gimp.gimp -v 2.10.18
Multiple apps found matching input criteria. Please refine the input.
Name Id        Version
----------------------
GIMP gimp.gimp 2.10.18
GIMP Gimp.Gimp 2.10.0

@JohnMcPMS JohnMcPMS added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 20, 2020
@ghost ghost added the Needs-Tag-Fix label May 20, 2020
@JohnMcPMS JohnMcPMS removed Issue-Feature This is a feature request for the Windows Package Manager client. Needs-Tag-Fix labels May 20, 2020
@ghost ghost added the Needs-Tag-Fix label May 20, 2020
@deepdvd
Copy link

deepdvd commented May 21, 2020

This worked for me.
winget install -e gimp.gimp

@doctordns
Copy link

Surely the right answer is to make the tool obey Windows defaults, and be case insensitive. OR make another tool called LinuxGet or Linget.exe.

@KorbenDev
Copy link

winget install -e gimp.gimp may work, but that's not a solution, it's a workaround.

Id's should be case insensitive und unique. . It's rediculous to have a package with the id "gimp.gimp" and one with "GIMP.GIMP". That only brings chaos to the repositories.

Do you want multiple versions of the same package in a repository? (It's not a rhetorical question, I would like to know). Then packages of the same software should have identical ids and different versions. And please add a --latest command switch.

PS: found another one. same id AND same version:

PS E:\> winget search coretemp
Name     Id             Version
--------------------------------
CoreTemp alcpu.coretemp 1.15.1.0
CoreTemp alcpu.CoreTemp 1.15.1

@doctordns
Copy link

IN this day age, why is case sensitivity even an issue? Except for legacy commands really should be case insensitive although capable of remembering case.

And even worse, If I attempt to install the coreremp package, I get:

PS C:\foo> winget install coretemp
Multiple apps found matching input criteria. Please refine the input.
Name     Id             Version
--------------------------------
CoreTemp alcpu.coretemp 1.15.1.0
CoreTemp alcpu.CoreTemp 1.15.1

How do I 'refine' the input? And since the "help" text says that the default is the later version why is this just not working (and installing coretemp)?

@deepdvd
Copy link

deepdvd commented May 23, 2020

How do I 'refine' the input? And since the "help" text says that the default is the later version why is this just not working (and installing coretemp)?

I think you refine it by using the -e (exact) parameter, or there would be no way to install it.

@doctordns
Copy link

Then why doesn't the error message say so?

Good commands have actionable output.

@denelon denelon modified the milestones: Package Manager Backlog, Package Manager v0.2 May 28, 2020
@martynhare
Copy link

martynhare commented Jun 21, 2020

My actual first experience with the product. Please make sure the product is case-insensitive like the rest of Win32. Otherwise, your product will quickly become unusable. This is not Linux and even if the future plan is to integrate Linux/Android apps, real-world distros like Debian use decent naming conventions to avoid this very issue.

Therefore, I urge you to just make things case-insensitive and possibly add a vendor field (backed by digital signature) rather than putting the vendor name in the ID.


C:\Users\Martyn>winget install GIMP.GIMP -v 2.10.20 --id gimp.gimp
Multiple apps found matching input criteria. Please refine the input.
Name Id        Version
----------------------
GIMP GIMP.GIMP 2.10.20
GIMP gimp.gimp 2.10.8

C:\Users\Martyn>winget install GIMP.GIMP -v 2.10.20 --id gimp.gimp -e
No app found matching input criteria.

C:\Users\Martyn>winget install --id gimp.gimp
Multiple apps found matching input criteria. Please refine the input.
Name Id        Version
----------------------
GIMP gimp.gimp 2.10.8
GIMP GIMP.GIMP 2.10.20

C:\Users\Martyn>winget install --id gimp.gimp -e
Found GIMP [gimp.gimp]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.gimp.org/mirror/pub/gimp/v2.10/windows/gimp-2.10.8-setup.exe
  ██████████████████████████████   189 MB /  189 MB
Successfully verified installer hash
Installing ...
Successfully installed!

@ghost ghost added the In-PR Issue related to a PR label Jun 25, 2020
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jun 26, 2020
@JohnMcPMS
Copy link
Member

Sorry, was unaware of the github magic incantation that was closing the issue based on the PR. Will avoid that in the future so that the issue can stay open until it is publicly available.

@JohnMcPMS JohnMcPMS reopened this Jun 26, 2020
@denelon
Copy link
Contributor

denelon commented Aug 21, 2020

@denelon denelon closed this as completed Aug 21, 2020
@denelon denelon modified the milestones: Package Manager v0.2.x, v1.0 - Windows Package Manager May 4, 2021
@denelon denelon added this to Done in Client-Current May 6, 2021
@denelon denelon removed this from Done in Client-Current Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants