Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive installation parameter does not work #365

Closed
chrpai opened this issue May 29, 2020 · 7 comments
Closed

Interactive installation parameter does not work #365

chrpai opened this issue May 29, 2020 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@chrpai
Copy link

chrpai commented May 29, 2020

Brief description of your issue

winget install -i for an MSI pkg doesn't provide an interactive experience.

Steps to reproduce

winget install -i iswix

I authored the iswix.msi and iswix winget-pkg. I simply provided the url to the installer and that it was type .msi. No arguments, -i and -s all provide a silent installation. I would expect winget-cli to automatically know how to set the MSI UILevel property since the command line help shows these options.

Expected behavior

I'd expect the installer to be called with UILevel 5 so that the MSI wizard loop to appear so I can do advanced selections.

Actual behavior

The resulting logfile shows UILevel is set to 2 whether I include the -i switch or not.

Environment

Windows: Windows.Desktop v10.0.19635.1
Package: Microsoft.DesktopAppInstaller v1.0.41331.0

[winget --info]
Windows Package Manager version
Windows: Windows.Desktop version
Package: Microsoft.DesktopAppInstaller version

Any other software?
@ghost ghost added the Needs-Triage Issue need to be triaged label May 29, 2020
@megamorf
Copy link

I don't understand the issue description to be honest. A silent (a.k.a unattended) installation is the opposite of an interactive installation. Are you asking to be able to provide some sort of parameter to the winget install command that turns an unattended installation into an interactive one? Why not simply do winget show, use the displayed download url to pull the installer and run it manually?

PS C:\Users\megamorf> winget show -e --id Git.Git
Found Git [Git.Git]
Version: 2.26.2
Publisher: Git
Description: Git version control system.
Homepage: https://git-scm.com/
License: GNU General Public License, version 2
License Url: https://github.com/git-for-windows/git/blob/master/COPYING
Installer:
  SHA256: cdf76510979dace4d3f5368e2f55d4289c405e249399e7ed09049765489da6e8
  Download Url: https://github.com/git-for-windows/git/releases/download/v2.26.2.windows.1/Git-2.26.2-64-bit.exe
  Type: Inno

@chrpai
Copy link
Author

chrpai commented May 29, 2020

winget install -? already documents a switch for interactive installations. For an MSI this is standard behavior to pass a /QN for silent installation or don't pass it for interactive. For EXE installers it's typically adding a /S or not.

The following options are available:
-m,--manifest The path to the manifest of the application
--id Filter results by id
--name Filter results by name
--moniker Filter results by app moniker
-v,--version Use the specified version; default is the latest version
-s,--source Find app using the specified source
-e,--exact Find app using exact match
-i,--interactive Request interactive installation; user input may be needed
-h,--silent Request silent installation
-o,--log Log location (if supported)
--override Override arguments to be passed on to the installer
-l,--location Location to install to (if supported)

@megamorf
Copy link

Ah, I had to read your last response and then your original issue a number of times to actually understand what you consider the problem.

I would recommend updating your original issue description and title to more clearly describe the issue and provide a concrete test case.

Title suggestion:
Requesting interactive installation parameter results in silent installation or Interactive installation parameter does not work.

@chrpai chrpai changed the title install interactive installs silent Interactive installation parameter does not work May 29, 2020
@chrpai
Copy link
Author

chrpai commented May 29, 2020

I'm glad that you finally understand this simple problem. I think it was worded just fine but I updated it to try to make you happy.

PS- I'm not sure why I would use winget show to manually download and install the MSI. That kind of defeats the purpose of winget doesn't it?

@megamorf
Copy link

megamorf commented May 29, 2020

To me the purpose of winget is to run unattended installations of libraries and applications. I might want to add additional parameters that I want to be passed to the embedded installer to customize the installation. In my opinion winget resembles a typical command line tool like homebrew, apt or chocolatey for which I never had the need to run an interactive setup. If I wanted an interactive installation I would not expect winget to do that for me - I'd grab the setup file and run it interactively completely bypassing winget.

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jun 2, 2020
@denelon denelon modified the milestones: Package Manager Backlog, Package Manager v0.2 Jun 2, 2020
@chausner
Copy link
Contributor

chausner commented Jun 3, 2020

If I wanted an interactive installation I would not expect winget to do that for me - I'd grab the setup file and run it interactively completely bypassing winget.

Unattended installations, e.g. as part of a batch file, are one usecase. But I see winget also as a tool for people that want to go through the normal installation wizard (e.g. to customize installation options) but that do not want to go through all the manual steps of searching the Internet first for the homepage, downloading the right installer, installing, deleting the installer, etc.

@denelon
Copy link
Contributor

denelon commented Jul 29, 2020

@denelon denelon closed this as completed Jul 29, 2020
@denelon denelon modified the milestones: Package Manager v0.2.x, v1.0 - Windows Package Manager May 4, 2021
@denelon denelon added this to Done in Client-Current May 6, 2021
@denelon denelon removed this from Done in Client-Current Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

5 participants