Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade --all will execute update flow for denied packages #4298

Open
mdanish-kh opened this issue Mar 23, 2024 · 2 comments · May be fixed by #4300
Open

upgrade --all will execute update flow for denied packages #4298

mdanish-kh opened this issue Mar 23, 2024 · 2 comments · May be fixed by #4300
Labels
Command-Upgrade Issue related to WinGet Upgrade Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@mdanish-kh
Copy link
Contributor

Brief description of your issue

When a package has UpgradeBehavior: deny set, I expect winget upgrade <Package> and winget upgrade --all to block updating the package. Turns out winget upgrade --all still tries to update the execute flow.

Steps to reproduce

  1. Have a denied package that has an upgrade available (Take MSYS2.MSYS2 for example)
  2. Run winget upgrade MSYS2.MSYS2
  3. Package is blocked correctly
  4. Run winget upgrade --all
  5. winget tries to upgrade MSYS2.MSYS2

image

image

Expected behavior

Package is blocked from upgrade

Actual behavior

WinGet tries to upgrade the package

Environment

Windows Package Manager v1.7.10661
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3296
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.10661.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Enabled
LocalArchiveMalwareScanOverride           Disabled
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Mar 23, 2024
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Mar 23, 2024

[Policy] Issue-Bug
[Policy] Command-Upgrade

Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Command-Upgrade Issue related to WinGet Upgrade and removed Needs-Triage Issue need to be triaged labels Mar 23, 2024
@Trenly Trenly linked a pull request Mar 23, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-Upgrade Issue related to WinGet Upgrade Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant