Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception. System.FormatException: Input string was not in a correct format. #57

Closed
BitSec01 opened this issue Jun 2, 2021 · 5 comments

Comments

@BitSec01
Copy link

BitSec01 commented Jun 2, 2021

Hello while making a manifest file for Docker I received the following error:

Unhandled exception. System.FormatException: Input string was not in a correct format.
   at System.Text.ValueStringBuilder.ThrowFormatError()
   at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.FormatHelper(IFormatProvider provider, String format, ParamsArray args)
   at System.String.Format(String format, Object[] args)
   at Microsoft.WingetCreateCLI.Logging.Logger.Log(LogLevel level, String format, Object[] args)
   at Microsoft.WingetCreateCLI.Logging.Logger.Error(String message, Object[] args)
   at Microsoft.WingetCreateCLI.Program.Main(String[] args)
   at Microsoft.WingetCreateCLI.Program.<Main>(String[] args)

Steps to reproduce

  1. Enter URL: https://desktop.docker.com/win/stable/amd64/Docker%20Desktop%20Installer.exe
  2. Press enter 7 times until you get to ShortDescription
  3. Change short description to Docker Desktop for Windows
  4. Press Enter
  5. Would you like to make changes? Press Y and then Enter
  6. Press Enter for the remaining questions
  7. Then press Y and Enter to submit to package manager repository
  8. Fill in the github code and Enter
  9. Fill in Password and press Enter
  10. Then error shows up
@ghost ghost added the Needs-Triage label Jun 2, 2021
@ryfu-msft
Copy link
Contributor

Hi @RamonRobben,

Thank you for this, I will investigate this bug further. Were you still able to submit a pull request or did the error terminate before that process could take place? I'm not seeing your PR in winget-pkgs so I'm assuming no.

@BitSec01
Copy link
Author

BitSec01 commented Jun 2, 2021

Hi @RamonRobben,

Thank you for this, I will investigate this bug further. Were you still able to submit a pull request or did the error terminate before that process could take place? I'm not seeing your PR in winget-pkgs so I'm assuming no.

Hey, No unfortunately it did not submit a PR. I did however try to do it manually but it seems that there is already a package with that software. It just had a different name then what the program came up with. (DockerInc. vs Docker) And some different subfolder names.

@denelon denelon added this to the v.Next - `winget create` milestone Jun 2, 2021
@denelon denelon added this to To do in Create-Bugs Jun 2, 2021
@ryfu-msft
Copy link
Contributor

That's good to know! Regardless, we appreciate your contribution to our tool :) We are currently working on adding logic to the tool to check for existing packages to help avoid submitting duplicates. In case you didn't know, you can quickly check if a package already exists by entering winget search Docker in terminal or by searching for the package in the winget-pkgs repo.  Thanks again!

Hi @RamonRobben,
Thank you for this, I will investigate this bug further. Were you still able to submit a pull request or did the error terminate before that process could take place? I'm not seeing your PR in winget-pkgs so I'm assuming no.

Hey, No unfortunately it did not submit a PR. I did however try to do it manually but it seems that there is already a package with that software. It just had a different name then what the program came up with. (DockerInc. vs Docker) And some different subfolder names.

@palenshus
Copy link
Contributor

I believe this is a duplicate, please reactivate if you disagree

Duplicate of #49

@ghost
Copy link

ghost commented Jun 3, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 3, 2021
@ghost ghost added Resolution-Duplicate and removed In-PR labels Jun 3, 2021
@palenshus palenshus moved this from To do to Done in Create-Bugs Jun 3, 2021
@palenshus palenshus moved this from Done to Released in Create-Bugs Jun 16, 2021
@denelon denelon modified the milestones: v.Next-Create, v1.0-Create Oct 1, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Create-Bugs
Released
Development

No branches or pull requests

4 participants