Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: vim.vim #153513

Closed
2 tasks done
WojciechThomas opened this issue May 14, 2024 · 2 comments
Closed
2 tasks done

[Package Issue]: vim.vim #153513

WojciechThomas opened this issue May 14, 2024 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@WojciechThomas
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Winget updated Vim to version 9.1.312 (latest one) correctly.
Now every time it tries to update it, because the version (probably in the metadata) is 9.1.0312.

Steps to reproduce

Run command:

winget update 

Actual behavior

Vim 9.1.0312 is installed every time I call winget update:

(1/1) Found Vim [vim.vim] Version 9.1.0312
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/vim/vim-win32-installer/releases/download/v9.1.0312/gvim_9.1.0312_x64.exe
  ██████████████████████████████  10.7 MB / 10.7 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Expected behavior

Winget should not identify Vim 9.1.0312 as a new version of Vim 9.1.312

Environment

Windows Package Manager v1.7.11261
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3447
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.11261.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_XXXXXXXXXXXXX\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_XXXXXXXXXXXXX\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Screenshots and Logs

No response

@WojciechThomas WojciechThomas added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label May 14, 2024
@Utesgui
Copy link
Contributor

Utesgui commented May 14, 2024

This (stable) version of VIM seems to install as "9.1.0" instead of "9.1.0312" which it should according to the Manifest.
image

Either using the PackageVersion as Display Version (in ARP entries) or adding an AppsAndFeatures Block with the Display Version "9.1.0" to the Manifest would fix this.

However adding the Display Version to the manifest might prevent winget from updating to newer "versions" with the same Display Version (e.g. from 9.1.0211 to 9.1.0312 if both use Display Name 9.1.0)

@chrisbra

@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label May 14, 2024
@WojciechThomas
Copy link
Author

I can see that today, winget update installed Vim 9.1.412, and now everything seems to be ok. Subsequent updates do not display Vim 9.1.412 as not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants