Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android SDK Platform-Tools #4082

Open
Weirdo1312 opened this issue Oct 10, 2020 · 16 comments · May be fixed by #94818
Open

Android SDK Platform-Tools #4082

Weirdo1312 opened this issue Oct 10, 2020 · 16 comments · May be fixed by #94818
Labels
Blocking-Issue Manifest validation is blocked by a known issue. In-PR zip-binary Depends on library files that aren't available via symlink

Comments

@Weirdo1312
Copy link

Package Requested

Manifest:

Fill out as much of the manifest as you can:

Id: string # publisher.package format
Publisher: Google # the name of the publisher
Name: Android SDK Platform-Tools # the name of the application
Version: 30.0.4 # version numbering format
License: developer.android.com/license # the open source license or copyright
InstallerType: exe (standalone, no installer) # enumeration of supported installer types (exe, msi, msix, inno, wix, nullsoft, appx)
Installers:
  - Arch: string # enumeration of supported architectures
    Url: https://dl.google.com/android/repository/platform-tools_r30.0.4-windows.zip # path to download installation file
    Sha256: string # SHA256 calculated from installer
# ManifestVersion: 0.1.0
@Weirdo1312 Weirdo1312 added the Help-Wanted This is a good candidate work item from the community. label Oct 10, 2020
@ghost ghost added the Needs: Triage label Oct 10, 2020
@denelon
Copy link
Contributor

denelon commented Oct 19, 2020

@BarFin is this a duplicate of #3680?

@Weirdo1312
Copy link
Author

@BarFin is this a duplicate of #3680?

No, Android SDK platform tools are "adb" and "fastboot" command line tools for interacting with android phones with usb debugging enabled
like flashing some rom or recovery or rebooting into a specific img or and other good stuff
it's not for making android apps like android studio is

@ptanmay143
Copy link
Contributor

Package Requested

Manifest:

Fill out as much of the manifest as you can:

Id: string # publisher.package format
Publisher: Google # the name of the publisher
Name: Android SDK Platform-Tools # the name of the application
Version: 30.0.4 # version numbering format
License: developer.android.com/license # the open source license or copyright
InstallerType: exe (standalone, no installer) # enumeration of supported installer types (exe, msi, msix, inno, wix, nullsoft, appx)
Installers:
  - Arch: string # enumeration of supported architectures
    Url: https://dl.google.com/android/repository/platform-tools_r30.0.4-windows.zip # path to download installation file
    Sha256: string # SHA256 calculated from installer
# ManifestVersion: 0.1.0

The installer type is not exe. It is actually a zip which needs to be extracted and added to the PATH environment variable. Till winget gets zip install support, I don't think we can get Android platform tools being packaged here.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 6, 2021
@ghost
Copy link

ghost commented Jan 6, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Jan 14, 2021
@Weirdo1312
Copy link
Author

@denelon please remove "Needs feedback" tag

@ghost ghost removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 14, 2021
@denelon denelon reopened this Feb 3, 2021
@MattBDev
Copy link
Contributor

This should have the label ".zip" and "Blocking-Issue"

@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. .zip labels Apr 22, 2021
@denelon
Copy link
Contributor

denelon commented Apr 22, 2021

microsoft/winget-cli#859

@rollingmoai
Copy link

rollingmoai commented Mar 26, 2022 •
edited

microsoft/winget-cli#859

Shouldn't it be microsoft/winget-cli#140? (it's not an installer inside)

@denelon
Copy link
Contributor

denelon commented Mar 27, 2022

We will have support for a portable app:

first, then we will implement:

which will include:

@j2ghz
Copy link

j2ghz commented Oct 22, 2022

We will have support for a portable app:

first, then we will implement:

which will include:

These seem to be implemented, is this unblocked now?

@vedantmgoyal9
Copy link
Contributor

cc @Trenly

@Trenly
Copy link
Contributor

Trenly commented Oct 23, 2022

We will have support for a portable app:

first, then we will implement:

which will include:

These seem to be implemented, is this unblocked now?

Not exactly. They have been implemented, but not yet released. I can create the manifest for it, but it won’t be able to be merged until the Winget Client version 1.4 is released to stable and about 50% of users have updated to the new version

@bet4it
Copy link

bet4it commented Jan 27, 2023

Could it be implemented now?

@sitiom sitiom linked a pull request Jan 27, 2023 that will close this issue
Draft
5 tasks
@sitiom
Copy link
Contributor

sitiom commented Jan 27, 2023 •
edited

@denelon
Copy link
Contributor

denelon commented Jan 27, 2023

@denelon denelon removed Blocking-Issue Manifest validation is blocked by a known issue. .zip labels Feb 22, 2023
@Trenly
Copy link
Contributor

Trenly commented Mar 10, 2023

Based on the discussion in the linked PR, this is a Zipped binary file and not just a portable EXE. Because of the way symlinks work, this is now blocked by microsoft/winget-cli#2711

cc @denelon for labeling with Zipped Binary

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 10, 2023
@denelon denelon added the zip-binary Depends on library files that aren't available via symlink label Mar 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Aug 3, 2023
@dvc94ch dvc94ch mentioned this issue Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocking-Issue Manifest validation is blocked by a known issue. In-PR zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New package: Google.Android.SDKPlatformTools version 33.0.3 sitiom/winget-pkgs
10 participants
@j2ghz @MattBDev @Trenly @bet4it @Weirdo1312 @ptanmay143 @sitiom @denelon @rollingmoai @vedantmgoyal9