Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libwebrtc m84 does not build on UWP ARM64 #44

Closed
fibann opened this issue Jul 2, 2020 · 1 comment · Fixed by #47
Closed

libwebrtc m84 does not build on UWP ARM64 #44

fibann opened this issue Jul 2, 2020 · 1 comment · Fixed by #47
Assignees
@LoadLibrary

Comments

@fibann
Copy link
Member

fibann commented Jul 2, 2020

Building after applying the patches in the m84 directory generates plenty of errors. See attached log for a comprehensive list (the used args.gn is also attached).
errors.zip
@LoadLibrary
Copy link
Contributor

The used build args are different from the ones used for validating the patches.

The following categories are observed from the attached build log:

  • BoringSSL not knowing the target platform
  • libjpeg_turbo unique use of C and Neon instructions
  • aec3 code issue with switch statement contains 'default' but no 'case' labels

WinRTC m80 has fixes for that issues. The fixes might not be copied over to m84 because some issue with the build process (left overs).

I'm going to clone WebRTC from scratch, apply the patches and build with both set of gn args.

@LoadLibrary LoadLibrary self-assigned this Jul 2, 2020
@LoadLibrary LoadLibrary mentioned this issue Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LoadLibrary LoadLibrary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding missing patch files for m84 microsoft/winrtc
2 participants
@LoadLibrary @fibann