Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A MenuFlyout with ToggleMenuFlyoutItems and MenuFlyoutSeparator has padding for icons/glyphs #112

Closed
2 of 12 tasks
Poopooracoocoo opened this issue Jul 2, 2019 · 3 comments

Comments

@Poopooracoocoo
Copy link

Describe the bug

A MenuFlyout with ToggleMenuflyoutItems and MenuFlyoutSeparator has padding for icons/glyphs

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Go to MenuFlyout
  2. Click on "Options" under "A MenuFlyout with ToggleMenuflyoutItems and MenuFlyoutSeparator has padding for icons/glyphs"

Expected behavior

image

Actual behavior

image

Screenshots

Version Info

Gallery version (found on Settings page):
1.2.8.0

Windows 10 version:

  • Insider Build (xxxxx)
  • May 2019 Update (18362)
  • October 2018 Update (17763)
  • April 2018 Update (17134)
  • Fall Creators Update (16299)
  • Creators Update (15063)
  • Anniversary Update (14393)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Additional context

@Poopooracoocoo Poopooracoocoo changed the title A MenuFlyout with ToggleMenuflyoutItems and MenuFlyoutSeparator has padding for icons/glyphs A MenuFlyout with ToggleMenuFlyoutItems and MenuFlyoutSeparator has padding for icons/glyphs Jul 2, 2019
@stmoy
Copy link
Contributor

stmoy commented Jul 2, 2019

The reason for the space is that the Repeat and Shuffle options can be toggled on. It looks strange when they are both toggled off, but here's what it looks like when one of them is toggled on:
image

This could be made clearer if the app had one of the items checked by default. This should be a quick fix so I'll keep this issue open to track that work.

@stmoy
Copy link
Contributor

stmoy commented Jul 2, 2019

I've updated the sample to have the items checked by default, which should hopefully make the reason for the "gap" more apparent. Thank you for reporting this @Poopooracoocoo

@stmoy stmoy closed this as completed Jul 2, 2019
@Poopooracoocoo
Copy link
Author

Poopooracoocoo commented Jul 3, 2019

Thanks! :D

I feel incredibly stupid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants