Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: expand capabilities of create_rank() #102

Closed
moralec opened this issue Mar 9, 2021 · 6 comments
Closed

Feature request: expand capabilities of create_rank() #102

moralec opened this issue Mar 9, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@moralec
Copy link
Contributor

moralec commented Mar 9, 2021

There are a few additional things we should add to rank functions:

In addition to absolute values (e.g. 10 collab hours), table should return

  • % difference relative to company average (200%)
  • P Value of t statistic (difference over average)

New opportunity plot:

image

@martinctc martinctc changed the title Expand capabilities of create_rank Feature request: expand capabilities of create_rank() Mar 10, 2021
@martinctc
Copy link
Member

This is a great view @moralec! A couple of questions for discussion:

  1. Is this simply a bubble (or scatter) plot where the background is overlaid with the impact areas?
  2. Follow-up to the above, should this be a scatter plot or a bubble plot (sizes scale to group size). A bubble plot would present duplicate (or emphasised) information because the vertical axis already represents group size.
  3. Is company average group size simply a mean taken over the relative sizes of the groups? E.g. 90 if Org A is 100, Org B is 90, and Org C is 80? And Org B will fall right in the middle at 1:1.
  4. Should this be a plot_mode = 3 option for create_rank()? Or would it be more intuitive to users to have a separate function?

@martinctc martinctc added the enhancement New feature or request label Mar 10, 2021
@moralec
Copy link
Contributor Author

moralec commented Mar 18, 2021

@martinctc found this! I think we can start with the table and then address the plot idea.
Maybe a good task for a someone that wants to make a contribution and still improving their R skills?

With respect to your questions above:

  1. Simple bubble chart should be fine
  2. Agree that is duplicated information, but I don't feel strongly about it. Technically the Y axis could be in dollar tearms for example. Also It helps emphasise the point.
  3. I think she means the average of that metric for the entire population
  4. Plot mode =3 sounds like the right approach

@martinctc martinctc linked a pull request Mar 23, 2021 that will close this issue
2 tasks
@moralec
Copy link
Contributor Author

moralec commented Mar 23, 2021

I think we should limit this change to:

  • New combine function
  • New basic columns for table (% over average, SD, median, P value for ttest )

@moralec
Copy link
Contributor Author

moralec commented Mar 23, 2021

@moralec
Copy link
Contributor Author

moralec commented Jul 6, 2021

Brining this back from the dead.

I think we should omit the opportunity plot, but really consider improving the table output by adding:

  • % difference relative to company average (200%)
  • P Value of t statistic (difference over average)

An example:
image

@moralec
Copy link
Contributor Author

moralec commented Jun 8, 2022

Merging with #170

@moralec moralec closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants