Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update plot visuals in collaboration_report() #69

Merged
merged 4 commits into from Feb 25, 2021
Merged

Feature: update plot visuals in collaboration_report() #69

merged 4 commits into from Feb 25, 2021

Conversation

moralec
Copy link
Contributor

@moralec moralec commented Feb 16, 2021 •
edited by martinctc

Summary

This branch updates the collaboration report with new visuals that are more relevant to the user.

Changes

The changes made in this PR are:

  1. New version of the collaboration report
  2. Changed a title in the create_rank() function for clarity

Checks

  • All R CMD checks pass
  • roxygenise() was run to generate documentation.

@martinctc martinctc changed the title Updated collaboration report Feature: update plot visuals in collaboration_report() Feb 16, 2021
@martinctc martinctc added the enhancement New feature or request label Feb 16, 2021
martinctc
martinctc approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@martinctc martinctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great @moralec, thanks!
All checks have passed and documentation is run, so happy for you to merge this in.

@martinctc martinctc added this to In progress in First CRAN Release v1.4.0 Feb 18, 2021
@moralec moralec merged commit 30fa506 into main Feb 25, 2021
First CRAN Release v1.4.0 automation moved this from In progress to Done Feb 25, 2021
@moralec moralec deleted the feature/collaboration_report branch February 25, 2021 10:31
@moralec moralec restored the feature/collaboration_report branch February 25, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinctc martinctc martinctc approved these changes

Assignees

@moralec moralec

Labels
enhancement New feature or request
Projects
No open projects
First CRAN Release v1.4.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moralec @martinctc