Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow eBPF to inspect discontiguous frames #514

Closed
mtfriesen opened this issue May 16, 2024 · 2 comments · Fixed by #518
Closed

Allow eBPF to inspect discontiguous frames #514

mtfriesen opened this issue May 16, 2024 · 2 comments · Fixed by #518
Assignees
Labels
ebpf feature request New feature or request P1
Milestone

Comments

@mtfriesen
Copy link
Contributor

mtfriesen commented May 16, 2024

  1. Provide the first XDP_BUFFER to eBPF for inspection
  2. Set a new XDP flag if there are more buffers (multi-buffer), which aligns to the currently understanding of the Linux analogue.
  3. Tests
@mtfriesen mtfriesen added feature request New feature or request ebpf labels May 16, 2024
@mtfriesen mtfriesen added this to the Release 1.1 milestone May 16, 2024
@mtfriesen mtfriesen self-assigned this May 16, 2024
@saxena-anurag
Copy link
Contributor

I think we may need to implement the below helper functions also to get the non-contiguous data?

1. u64 bpf_xdp_get_buff_len(struct xdp_buff *xdp_md)
2. long bpf_xdp_load_bytes(struct xdp_buff *xdp_md, u32 offset, void *buf, u32 len)
3. long bpf_xdp_store_bytes(struct xdp_buff *xdp_md, u32 offset, void *buf, u32 len)

@mtfriesen
Copy link
Contributor Author

We can, though I'm fine leaving that for a future feature enhancement. Our customer right now only needs to read the L2-L4 headers, which are practically required to be in the first contiguous buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ebpf feature request New feature or request P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants