Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OM writes id attribute on an <ec/> tag even if the id attribute is not set #3

Closed
rabularca opened this issue Nov 26, 2015 · 3 comments
Closed

OM writes id attribute on an <ec/> tag even if the id attribute is not set #3

rabularca opened this issue Nov 26, 2015 · 3 comments

Comments

@rabularca
Copy link

When creating a default StandaloneCodeEnd object and writing it back, then it automatically adds the id attribute with an empty string as the value.

For example, when writing back the tag , the OM will write it as

@chrismar77
Copy link
Contributor

Thanks for reporting this issue. We'll investigate and report back.

@RyanKing77
Copy link
Member

We have reproduced the issue and are preparing a fix. Thanks.

marcta76 added a commit that referenced this issue Feb 10, 2016
@marcta76
Fixes Xliff OM Issues Reported on GitHub
3f960c4 
This drop contains fixes for the following issues:
#1 - The validator shouldn't validate any <ec/> tags which have isolated
attribute set to "yes" and no id attribute -
#1

#2 - The validator shouldn't validate any <ec/> tags which have both id
and startRef attributes set -
#2

#3 - OM writes id attribute on an <ec/> tag even if the id attribute is
not set - #3

#6 - The validator should validate ref attributes on <sm/> tags which do
not contain note -
#6

#8 - One type of note reference type is accepted -
#8

#9 - Adding a Generic MarkedSpan element inside a Comment MarkedSpan
element will change the type to "comment" -
#9

#10 - <mrk> and <sm> elements with type="generic" should have the
"translate" attribute set explicitly -
#10
@RyanKing77
Copy link
Member

We have released this fix. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrismar77 @RyanKing77 @rabularca