Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Comparison report doesn't show full path of file being compared #332

Closed
SeanKilleen opened this issue Aug 22, 2023 · 2 comments
Closed

Comments

@SeanKilleen
Copy link

Stumbled across this tool and used it to compare XML files quickly and correctly. Thanks for the time saver!

I noticed that in the HTML output of the comparison report, the file we're comparing to doesn't appear to be listed -- just its directory. Screenshot:

image

I think it's because the XmlDiffBody resource string is defined as:

<data name="XmlDiffBody" xml:space="preserve">
<value>&lt;tr&gt;&lt;td&gt;&lt;/td&gt;&lt;td title='{0}'&gt;&lt;b&gt; File in editor : {1}&lt;/b&gt;&lt;/td&gt;
&lt;td title='{2}'&gt;&lt;b&gt; File to compare : {3}&lt;/b&gt;&lt;/td&gt;
&lt;/tr&gt;</value>
</data>

And when called, the directory is what's passed to it:

resultHtml.WriteLine(string.Format(SR.XmlDiffBody,
System.IO.Path.GetDirectoryName(sourceXmlFile),
sourceXmlFile,
System.IO.Path.GetDirectoryName(changedXmlFile),
changedXmlFile
));

This is just a drive-by issue so I haven't gotten to look into it deeply but figured I'd start by passing it along.

@lovettchris
Copy link
Member

Thanks for the bug report.

@lovettchris
Copy link
Member

File in editor : {1} is correct, this is picking up sourceXmlFile which is a full path.

Maybe this is fixed in a newer version because this is what I'm seeing:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants