Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for column-major layout in binary format? #23

Closed
johnstairs opened this issue Dec 5, 2022 · 1 comment
Closed

Support for column-major layout in binary format? #23

johnstairs opened this issue Dec 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@johnstairs
Copy link
Member

The C++ types for multi-dimensional arrays (yardl::FixedNDArray, yardl::NDArray, and yardl::DynamicNDArray) are all locked to row-major layout at compile-time.

We will eventually support languages that default to column-major ordering. HDF5 requires data to be written in row-major order, so we will need to convert. For the binary format, we could do the same, or we could prefix each array with a byte indicating the layout. This could avoid expensive permutations if readers and writers are both working with column-major ordering.

@johnstairs johnstairs added the enhancement New feature or request label Dec 5, 2022
@johnstairs
Copy link
Member Author

We will address this in #78

@johnstairs johnstairs reopened this Oct 17, 2023
@johnstairs johnstairs closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant