Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yardl version not yet defined or set during build #76

Closed
naegelejd opened this issue Oct 10, 2023 · 2 comments
Closed

yardl version not yet defined or set during build #76

naegelejd opened this issue Oct 10, 2023 · 2 comments

Comments

@naegelejd
Copy link
Contributor

Soon we'll need to actually version yardl, which may include:

  • Defining version in the repo
  • Configuring build to set version/commit in cmd/yardl.go
  • Tag and release

var (
// set during build
version = ""
commit = ""

@johnstairs
Copy link
Member

@naegelejd, I'm sure we can improve the process, but we we tag and release, and set the version on the binary.

$ wget -q https://github.com/microsoft/yardl/releases/download/v0.3.0/yardl_0.3.0_linux_x86_64.tar.gz

$ tar -xvf yardl_0.3.0_linux_x86_64.tar.gz 
LICENSE
NOTICE.txt
yardl

$ ./yardl --version
yardl version 0.3.0 commit b9465f513d149ba699da8531b65e3d786202d229

@naegelejd
Copy link
Contributor Author

Got it. This is done automatically by goreleaser in the Github CI workflow

if: github.event_name == 'push' && github.ref_type == 'tag'

- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v3
with:
version: v1.13.0
args: release --rm-dist

Doing this locally at build time is not a priority, so... closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants