Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use remark pluging logger #25

Closed
pelikhan opened this issue Jul 1, 2022 · 3 comments
Closed

use remark pluging logger #25

pelikhan opened this issue Jul 1, 2022 · 3 comments
Assignees
@rlisahuang
Labels
question Further information is requested

Comments

@pelikhan
Copy link
Member

pelikhan commented Jul 1, 2022

The second argumen of visit should be a logger; we should use that in order to get proper logging in the builds
@pelikhan
Copy link
Member Author

pelikhan commented Jul 1, 2022

Also add support for github annotations format

@rlisahuang
Copy link
Contributor

ref: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-warning-message
from: 663a786#commitcomment-77467560
(just linking everything together for my own reference)

@rlisahuang
Copy link
Contributor

API for visit: (tree: Node, test_node: string, visitor: Function, reverse?: boolean)

Doesn't seem to have an argument for a logger.

Is our current logging mechanism enough? If so we can close this one.

@rlisahuang rlisahuang added the question Further information is requested label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlisahuang rlisahuang

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pelikhan @rlisahuang