-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contents of MenuItemTemplate get placed inside a NavigationViewItem's ContentPresenter #343
Comments
The behavior is being changed exactly :) |
@serenaz What do you mean? is it already changed? Which build? how is this solved? Thanks :) |
Hi @serenaz! Can you provide more info on which SDK the behavior will be changed in? Is this expected in the upcoming Spring Creator's Update? Thanks! |
Hi! Sorry, I was under the impression that the change was coming in the spring update, but was just informed that it's not coming until the fall :/ In the meantime, would recommend the StackOverflow solution. |
@serenaz could you, please, post an example on how to get the desired result without the workaround that @binaryfunt posted on StackOverflow? Thanks in advance |
Issue still exists.
Now instead of inline items, use <NavigationView.MenuItemTemplate>
<DataTemplate>
<NavigationViewItem Icon="{Binding Icon}"/>
</DataTemplate>
</NavigationView.MenuItemTemplate> When rendered, the |
Please reopen this issue. |
Can confirm, exists in WinUI 3. |
If still relevant, please file this on Microsoft Q&A. Unfortunately, the scope of this feedback channel covers specific doc fixes. The community of experts and Microsoft engineers can provide timely answers to your broader technical questions. If you do create a thread over at Microsoft Q&A, it would be fantastic if you could share that link here so I can track the progress and potentially incorporate the technical details into our documentation. Though I'm marking this Issue as closed now, please treat this thread as an open thread for follow-ups. Thanks! |
Does this mean that the behavior in WinUI now matches that described by the page? |
@jwmsft @anawishnoff for visibility. Any pending doc updates we can make to clarify the above issue? |
If this is an issue/bug with the NavigationView control itself, I'd recommend someone file a bug on the main WinUI repo. I'm not sure where the issue is on the NavigationView doc itself, could you elaborate there? |
See this StackOverflow question for details. It means you cannot bind the
Icon
property of theNavgationViewItem
. This behaviour is unexpected and should be mentioned.In my opinion, the behaviour should be changed so that the contents of
MenuItemTemplate
can be a custom control, which could be aNavigationViewItem
if you wanted.Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: