Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of MenuItemTemplate get placed inside a NavigationViewItem's ContentPresenter #343

Closed
binaryfunt opened this issue Mar 18, 2018 — with docs.microsoft.com · 12 comments
Assignees
Labels
Pri2 product-feedback Indicates that the feedback was related to the product itself. unspecified/svc

Comments

Copy link
Contributor

See this StackOverflow question for details. It means you cannot bind the Icon property of the NavgationViewItem. This behaviour is unexpected and should be mentioned.

In my opinion, the behaviour should be changed so that the contents of MenuItemTemplate can be a custom control, which could be a NavigationViewItem if you wanted.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@serenaz
Copy link
Contributor

serenaz commented Mar 19, 2018

The behavior is being changed exactly :)

@serenaz serenaz closed this as completed Mar 19, 2018
@SuperJMN
Copy link
Contributor

@serenaz What do you mean? is it already changed? Which build? how is this solved? Thanks :)

@LanceMcCarthy
Copy link
Contributor

Hi @serenaz!

Can you provide more info on which SDK the behavior will be changed in? Is this expected in the upcoming Spring Creator's Update?

Thanks!

@serenaz
Copy link
Contributor

serenaz commented Mar 22, 2018

Hi! Sorry, I was under the impression that the change was coming in the spring update, but was just informed that it's not coming until the fall :/ In the meantime, would recommend the StackOverflow solution.

@SuperJMN
Copy link
Contributor

SuperJMN commented May 25, 2019

@serenaz could you, please, post an example on how to get the desired result without the workaround that @binaryfunt posted on StackOverflow?

Thanks in advance

@weitzhandler
Copy link
Contributor

Issue still exists.
The issue is very easy to reproduce:

  • Create a NavigtionView and set inline NavigationViewItems to it.
  • Run it and observe the icon displaying and hiding according to screen

Now instead of inline items, use NavigationView.MenuItemTemplate:

<NavigationView.MenuItemTemplate>
  <DataTemplate>
    <NavigationViewItem Icon="{Binding Icon}"/>
  </DataTemplate>
</NavigationView.MenuItemTemplate>

When rendered, the NavigationViewItem is no longer responsive to the screen size or the navigation view mode.
This issue shouldn't have been closed.

@weitzhandler
Copy link
Contributor

Please reopen this issue.
The error issue still persists.

@sharpninja
Copy link

Please reopen this issue.
The error issue still persists.

Can confirm, exists in WinUI 3.

@mijacobs mijacobs reopened this Apr 2, 2020
@wdkbot wdkbot assigned serenaz and unassigned GrantMeStrength and jwmsft Apr 2, 2020
@mijacobs mijacobs assigned jwmsft and unassigned serenaz Apr 2, 2020
@PRMerger7 PRMerger7 added the Pri2 label Jun 19, 2020
@hkhmsft hkhmsft added the product-feedback Indicates that the feedback was related to the product itself. label Jan 25, 2021
@hkhmsft
Copy link
Contributor

hkhmsft commented Jan 25, 2021

If still relevant, please file this on Microsoft Q&A. Unfortunately, the scope of this feedback channel covers specific doc fixes. The community of experts and Microsoft engineers can provide timely answers to your broader technical questions. If you do create a thread over at Microsoft Q&A, it would be fantastic if you could share that link here so I can track the progress and potentially incorporate the technical details into our documentation.

Though I'm marking this Issue as closed now, please treat this thread as an open thread for follow-ups. Thanks!

@hkhmsft hkhmsft closed this as completed Jan 25, 2021
@sharpninja
Copy link

Unfortunately, the scope of this feedback channel covers specific doc fixes.

Does this mean that the behavior in WinUI now matches that described by the page?

@hkhmsft
Copy link
Contributor

hkhmsft commented Jan 25, 2021

@jwmsft @anawishnoff for visibility. Any pending doc updates we can make to clarify the above issue?

@anawishnoff
Copy link

If this is an issue/bug with the NavigationView control itself, I'd recommend someone file a bug on the main WinUI repo. I'm not sure where the issue is on the NavigationView doc itself, could you elaborate there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri2 product-feedback Indicates that the feedback was related to the product itself. unspecified/svc
Projects
None yet
Development

No branches or pull requests