Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

The cached _graphClient instance in GraphSDKHelper is not used #4

Closed
John-Garland opened this issue Oct 6, 2017 · 2 comments
Closed

Comments

@John-Garland
Copy link

The _graphClient field in GraphSDK helper appears to be there in order to cache the reference between executions of the GetAuthenticatedClient method. Except that the private field is only ever referenced from this function, and is generated new for every single function call. Either the call needs to be changed to check it against null and then create the instance if null, or the variable can be moved from a field to a local function variable.

@jamescro
Copy link

jamescro commented Oct 6, 2017

Thanks for spotting this. That field is a vestige of an earlier version of the sample, and we're no longer following that pattern. We'll remove it in the next week or two.

@mark-szabo mark-szabo added the bug label Oct 9, 2017
@mark-szabo
Copy link
Contributor

Hi @dotnetgator, in theory this should have fixed too with the new MSAL implementation. Please have a look and reopen if you find the issue valid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants