Fix: Add tooltips and correct color contrast #619
Conversation
|
I see two "more actions" tooltips when hovering over the gear icon.
|
| ariaLabel='Minimise sidebar' | ||
| onClick={() => toggleSidebar()} /> | ||
| <TooltipHost | ||
| content='Minimise sidebar' |
There was a problem hiding this comment.
misspelt. should be z
@ddyett depends on which english pronunciation you're using 👽
There was a problem hiding this comment.
all the more reason for localization. since the most popular page is en-US probably should be z.
|
@ddyett @bettirosengugi @ElinorW @thewahome I am interested in knowing what you guys think about replacing the settings icon with a context menu icon. The settings icon is used for updating user settings or profile in apps. The context menu icon is used for showing more actions. Sample Context Menu Icon |
|
not sure how i feel about the icon. there are some settings like actions and some more actions like actions. i'd have to think about it. |
|
@ddyett these are a closer representation of how the context-menu icons look like in uifabric-react |
Overview
Added tooltips to the 'minimize sidebar' and 'more actions' icons displayed to enhance keyboard navigation.
Changed the color of the "patch" drop-down control to fit the color contrast ratio.
Demo
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions