Fix: failing create teams request #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyett
reviewed
Jul 13, 2020
src/app/views/common/share.ts
Outdated
| } | ||
|
|
||
| if (sampleHeaders && sampleHeaders.length > 0) { | ||
| const headers = hashEncode(JSON.stringify(sampleHeaders)); | ||
| shareLink = `${shareLink}&headers=${headers}`; | ||
| shareLink += `${shareLink}&headers=${headers}`; |
There was a problem hiding this comment.
shouldn't this be removed or stay as before?
There was a problem hiding this comment.
It should actually stay as before
ddyett
reviewed
Jul 13, 2020
| @@ -66,7 +66,7 @@ export class QueryInput extends Component<IQueryInputProps, any> { | |||
| background: getStyleFor(selectedVerb), | |||
| }; | |||
|
|
|||
| const httpMethodsToDisplay = (mode === Mode.TryIt && !authenticated ) ? [httpMethods[0]] : httpMethods; | |||
| const httpMethodsToDisplay = (mode === Mode.TryIt || !authenticated) ? [httpMethods[0]] : httpMethods; | |||
There was a problem hiding this comment.
probably correct but we should consider if users may be confused minus text to say they need to sign in.
ddyett
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Running the
create a teamquery breaks the app like soThe characters previously unsupported when hashEncoding are now supported.
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions
https://graph.microsoft.com/beta/teamsadding the request body described in the docs here