Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Message bar truncation #679

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Fix: Message bar truncation #679

merged 1 commit into from
Sep 1, 2020

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Sep 1, 2020

Overview

Fix message truncation on the tip message bar
Fixes #678

Demo

image

Notes

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

thewahome
thewahome approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElinorW ElinorW merged commit 569bf53 into dev Sep 1, 2020
@ElinorW ElinorW deleted the fix/tip-message branch September 1, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tip Messages are being truncated on Graph Explorer
2 participants
@ElinorW @thewahome