Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show template variables #287

Merged
5 commits merged into from
Nov 13, 2019
Merged

Fix: show template variables #287

5 commits merged into from
Nov 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2019

Overview

Request urls with values like {group-id} were not being substituted with the relevant value.

Closes #270
Closes #220

Demo

image

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Select the user by email query
  • Notice the url has an email attached
  • Sign in to Graph Explorer
  • Notice the url has your email attached

@ghost ghost requested review from jobala and irvinesunday November 12, 2019 18:19
Copy link
Contributor

@jobala jobala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The password in the request body when you click on the create user sample should be auto-generated.

@irvinesunday
Copy link
Contributor

The password in the request body when you click on the create user sample should be auto-generated.

I thought this was to be handled from the API side. This PR does that: microsoftgraph/microsoft-graph-devx-api#158

1 similar comment
@irvinesunday
Copy link
Contributor

The password in the request body when you click on the create user sample should be auto-generated.

I thought this was to be handled from the API side. This PR does that: microsoftgraph/microsoft-graph-devx-api#158

@ghost
Copy link
Author

ghost commented Nov 13, 2019

The password in the request body when you click on the create user sample should be auto-generated.

I thought this was to be handled from the API side. This PR does that: microsoftgraph/microsoft-graph-explorer-api#158

Yes @irvinesunday. This fix caters for the cached version.

@ghost ghost merged commit 65ba338 into dev Nov 13, 2019
@jobala jobala deleted the fix/show-template-variables branch January 8, 2020 08:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants