Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sign in spinner does not stop spinning when authentication fails or is aborted #487

Closed
thewahome opened this issue Apr 27, 2020 · 0 comments · Fixed by #492
Closed

The sign in spinner does not stop spinning when authentication fails or is aborted #487

thewahome opened this issue Apr 27, 2020 · 0 comments · Fixed by #492
Assignees
@thewahome
Labels
Area: Authentication type:bug Something isn't working
Projects
Graph Explorer V4
Milestone
v4.1.1

Comments

@thewahome
Copy link
Collaborator

Describe the bug
When you try to sign in, then cancel mid way, the rotating sign in progress bar keeps rotating even after sign in process has been aborted.

This also happens when there's a problem in the sign in process, instead of showing the user the correct error, the progress bar keeps rotating giving the user false hope, till they reload the page and there they see the sign in button again.

Expected behavior
When sign in fails or succeeds or is aborted, the spinner should stop spinning.
@thewahome thewahome added type:bug Something isn't working Sign-In labels Apr 27, 2020
@thewahome thewahome self-assigned this Apr 27, 2020
@thewahome thewahome mentioned this issue Apr 27, 2020
Closed
@thewahome thewahome added this to the v4.1.1 milestone Apr 27, 2020
@thewahome thewahome mentioned this issue Apr 29, 2020
Merged
@thewahome thewahome added this to Under Review in Graph Explorer V4 Apr 29, 2020
Graph Explorer V4 automation moved this from Under Review to Done May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thewahome thewahome

Labels
Area: Authentication type:bug Something isn't working
Projects
No open projects
Graph Explorer V4
  
Done
Milestone
v4.1.1
Development

Successfully merging a pull request may close this issue.

Fix infinite spinning when login fails microsoftgraph/microsoft-graph-explorer-v4
2 participants
@adhiambovivian @thewahome