Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned sign-in leaves UI in unexpected state #531

Closed
MIchaelMainer opened this issue May 7, 2020 · 1 comment · Fixed by #492
Closed

Abandoned sign-in leaves UI in unexpected state #531

MIchaelMainer opened this issue May 7, 2020 · 1 comment · Fixed by #492

Comments

@MIchaelMainer
Copy link
Contributor

Describe the bug
Select login, and the login account selection browser window is opened with focus. If you close the login account selection browser window, the

To Reproduce
Steps to reproduce the behavior:

  1. Go to Sign into Graph Explorer. The login account selection browser window is opened.
  2. Abandon the login by closing the account selection browser window.

Expected behavior
The abandoned login should result in a UI state that doesn't represent an in progress login. We may want to remove the progress indicator as I don't know if there is a way to message back onClose of the login account select browser window..

Screenshots
This image shows the state
Bad sign in state

https://developer.microsoft.com/en-us/graph/graph-explorer/preview

Desktop (please complete the following information):

  • Browser: chrome
@thewahome thewahome linked a pull request May 8, 2020 that will close this issue
@Shjokie
Copy link
Contributor

Shjokie commented May 12, 2020

This has been fixed by #492

@Shjokie Shjokie closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants