Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non wellformed JSON for request bodies #557

Closed
MIchaelMainer opened this issue May 26, 2020 · 9 comments · Fixed by #577
Closed

Handle non wellformed JSON for request bodies #557

MIchaelMainer opened this issue May 26, 2020 · 9 comments · Fixed by #577
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@MIchaelMainer
Copy link
Contributor

Describe the bug
Request bodies with trailing JSON commas cause Graph Explorer to perform in an unexpected way. JSON spec does not allow trailing commas.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Graph Explorer
  2. Sign in.
  3. Create a POST or PATCH request with a request body that contains a trailing comma.
  4. See error in console.

Expected behavior
We show an error message stating that the supplied JSON is invalid.

Screenshots
image

**Desktop **

  • Browser chrome, edge

Additional context
Incident 187938447

@JimmyLS
Copy link

JimmyLS commented May 27, 2020

Based on my testing, the issue occurred if request syntax error (like invalid JSON) detected in PATCH/POST method, or even send an empty request body.
No error indicated user to correct request syntax, the query just stuck or hang there without any response until you refresh browser.
This is quite confusing and annoying experience to users.

@thewahome thewahome self-assigned this May 27, 2020
@thewahome thewahome added this to To do in Graph Explorer V4 via automation May 27, 2020
@Shjokie Shjokie added the type:bug Something isn't working label May 27, 2020
@JimmyLS
Copy link

JimmyLS commented Jun 2, 2020

Hi Guys,

Just want to check when we can fix this bug?

Thanks.

@MIchaelMainer MIchaelMainer changed the title Handle trailing commas for request bodies Handle non wellformed JSON for request bodies Jun 3, 2020
Graph Explorer V4 automation moved this from To do to Done Jun 8, 2020
@thewahome thewahome added this to the 4.1.3 milestone Jun 9, 2020
@JimmyLS
Copy link

JimmyLS commented Jun 10, 2020

Hi Team,

It's still not working on my side. The symptom is the same.

image

@ddyett
Copy link

ddyett commented Jun 10, 2020

this change hasn't deployed yet. Current schedule is later this week.

@JimmyLS
Copy link

JimmyLS commented Jun 11, 2020

this change hasn't deployed yet. Current schedule is later this week.

Thanks! I will try this next Monday.

@JimmyLS
Copy link

JimmyLS commented Jun 19, 2020

Hi Team,

May I know if the change has been deployed now? I tried it today but looks like still didn't work.

Thanks.

@JimmyLS
Copy link

JimmyLS commented Jun 19, 2020

Sorry, I test in the local instance and it worked, version 4.1.3.

May I know then this version can be published to the public instance?

@MIchaelMainer
Copy link
Contributor Author

@JimmyLS We are awaiting a resolution to a related deployment blocker.

@JimmyLS
Copy link

JimmyLS commented Jun 23, 2020

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants