Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Show log-out on try it on mobile screens #569

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Fix: Show log-out on try it on mobile screens #569

merged 2 commits into from
Jun 2, 2020

Conversation

thewahome
Copy link
Collaborator

Overview

Displays the login screen in mobile views

Fixes #561

Demo

image

Notes

N/A

Testing Instructions

  • Load GE in try it mode
  • Minimise screen till it hits the mobile view
  • Notice you can still see the dropdown

@thewahome thewahome requested a review from Shjokie June 2, 2020 06:19
@thewahome thewahome merged commit 18636e4 into dev Jun 2, 2020
@thewahome thewahome deleted the fix/show-logout-on-try-it-mobile branch June 25, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shjokie Shjokie Awaiting requested review from Shjokie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop down button on Try it that shows the logout feature does not show on some screen sizes
1 participant
@thewahome